Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Unified Diff: ios/web/public/test/js_test_util.h

Issue 2920303003: [ObjC ARC] Converts ios/web/public/test:test to ARC. (Closed)
Patch Set: unsafe_unretained Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/public/test/BUILD.gn ('k') | ios/web/public/test/js_test_util.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/public/test/js_test_util.h
diff --git a/ios/web/public/test/js_test_util.h b/ios/web/public/test/js_test_util.h
index ea21a5098a0ed6ab97ea5962312a2a35438af346..c7b1e80de4369ee7e1d14f5632b79e43f54e9a1b 100644
--- a/ios/web/public/test/js_test_util.h
+++ b/ios/web/public/test/js_test_util.h
@@ -27,7 +27,11 @@ id ExecuteJavaScript(CRWJSInjectionReceiver* receiver, NSString* script);
// Executes JavaScript on |web_view| and returns the result as an id.
// |error| can be null and will be updated only if script execution fails.
-id ExecuteJavaScript(WKWebView* web_view, NSString* script, NSError** error);
+// TODO(crbug.com/730062): Remove __unsafe_unretained when all callers are
+// are converted to ARC.
baxley 2017/06/06 17:16:48 Here's an example where this was done in another f
+id ExecuteJavaScript(WKWebView* web_view,
+ NSString* script,
+ NSError* __unsafe_unretained* error);
// Executes JavaScript on |web_view| and returns the result as an id.
// Fails if there was an error during script execution.
« no previous file with comments | « ios/web/public/test/BUILD.gn ('k') | ios/web/public/test/js_test_util.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698