Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2920253004: Revert "Revert "Make ClosureTask only accept Element-level APIs instead of resolvedAst."" (Closed)

Created:
3 years, 6 months ago by Emily Fortuna
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Revert "Make ClosureTask only accept Element-level APIs instead of resolvedAst."" This reverts commit 7bd51eb191f66110bc61be3859433368544fafd9. BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/faaba67a9159e9ab59687c5f33901888338d78c4

Patch Set 1 #

Patch Set 2 : fix teh tests #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -27 lines) Patch
M pkg/compiler/lib/src/closure.dart View 1 4 chunks +12 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/dump_info.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/builder.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/builder_kernel.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/serialization/model_test_helper.dart View 1 1 chunk +4 lines, -4 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
Emily Fortuna
I ran ALL the tests. The best tests. *ahem* hopefully this should fix everything.
3 years, 6 months ago (2017-06-05 22:08:27 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2920253004/diff/20001/tests/compiler/dart2js/serialization/model_test_helper.dart File tests/compiler/dart2js/serialization/model_test_helper.dart (right): https://codereview.chromium.org/2920253004/diff/20001/tests/compiler/dart2js/serialization/model_test_helper.dart#newcode163 tests/compiler/dart2js/serialization/model_test_helper.dart:163: AstElement astElement1 = element1; you might be able ...
3 years, 6 months ago (2017-06-05 22:27:04 UTC) #3
Emily Fortuna
https://codereview.chromium.org/2920253004/diff/20001/tests/compiler/dart2js/serialization/model_test_helper.dart File tests/compiler/dart2js/serialization/model_test_helper.dart (right): https://codereview.chromium.org/2920253004/diff/20001/tests/compiler/dart2js/serialization/model_test_helper.dart#newcode163 tests/compiler/dart2js/serialization/model_test_helper.dart:163: AstElement astElement1 = element1; On 2017/06/05 22:27:04, Siggi Cherem ...
3 years, 6 months ago (2017-06-05 22:30:22 UTC) #4
Emily Fortuna
3 years, 6 months ago (2017-06-05 22:36:32 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
faaba67a9159e9ab59687c5f33901888338d78c4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698