Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(831)

Side by Side Diff: pkg/compiler/lib/src/dump_info.dart

Issue 2920253004: Revert "Revert "Make ClosureTask only accept Element-level APIs instead of resolvedAst."" (Closed)
Patch Set: fix teh tests Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library dump_info; 5 library dump_info;
6 6
7 import 'dart:convert' 7 import 'dart:convert'
8 show ChunkedConversionSink, JsonEncoder, StringConversionSink; 8 show ChunkedConversionSink, JsonEncoder, StringConversionSink;
9 9
10 import 'package:dart2js_info/info.dart'; 10 import 'package:dart2js_info/info.dart';
(...skipping 197 matching lines...) Expand 10 before | Expand all | Expand 10 after
208 } 208 }
209 209
210 ClosureInfo visitClosureClassElement(ClosureClassElement element, _) { 210 ClosureInfo visitClosureClassElement(ClosureClassElement element, _) {
211 ClosureInfo closureInfo = new ClosureInfo( 211 ClosureInfo closureInfo = new ClosureInfo(
212 name: element.name, 212 name: element.name,
213 outputUnit: _unitInfoForElement(element), 213 outputUnit: _unitInfoForElement(element),
214 size: compiler.dumpInfoTask.sizeOf(element)); 214 size: compiler.dumpInfoTask.sizeOf(element));
215 _elementToInfo[element] = closureInfo; 215 _elementToInfo[element] = closureInfo;
216 216
217 ClosureClassMap closureMap = compiler.closureToClassMapper 217 ClosureClassMap closureMap = compiler.closureToClassMapper
218 .getClosureToClassMapping(element.methodElement.resolvedAst); 218 .getClosureToClassMapping(element.methodElement);
219 assert(closureMap != null && closureMap.closureClassElement == element); 219 assert(closureMap != null && closureMap.closureClassElement == element);
220 220
221 FunctionInfo functionInfo = this.process(closureMap.callElement); 221 FunctionInfo functionInfo = this.process(closureMap.callElement);
222 if (functionInfo == null) return null; 222 if (functionInfo == null) return null;
223 closureInfo.function = functionInfo; 223 closureInfo.function = functionInfo;
224 functionInfo.parent = closureInfo; 224 functionInfo.parent = closureInfo;
225 225
226 result.closures.add(closureInfo); 226 result.closures.add(closureInfo);
227 return closureInfo; 227 return closureInfo;
228 } 228 }
(...skipping 383 matching lines...) Expand 10 before | Expand all | Expand 10 after
612 612
613 ChunkedConversionSink<Object> sink = encoder.startChunkedConversion( 613 ChunkedConversionSink<Object> sink = encoder.startChunkedConversion(
614 new StringConversionSink.fromStringSink(buffer)); 614 new StringConversionSink.fromStringSink(buffer));
615 sink.add(new AllInfoJsonCodec().encode(result)); 615 sink.add(new AllInfoJsonCodec().encode(result));
616 compiler.reporter.reportInfo(NO_LOCATION_SPANNABLE, MessageKind.GENERIC, { 616 compiler.reporter.reportInfo(NO_LOCATION_SPANNABLE, MessageKind.GENERIC, {
617 'text': "View the dumped .info.json file at " 617 'text': "View the dumped .info.json file at "
618 "https://dart-lang.github.io/dump-info-visualizer" 618 "https://dart-lang.github.io/dump-info-visualizer"
619 }); 619 });
620 } 620 }
621 } 621 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698