tests/compiler/dart2js/serialization/model_test_helper.dart - Issue 2920253004: Revert "Revert "Make ClosureTask only accept Element-level APIs instead of resolvedAst.""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/compiler/dart2js/serialization/model_test_helper.dart

Issue 2920253004: Revert "Revert "Make ClosureTask only accept Element-level APIs instead of resolvedAst."" (Closed)

Patch Set: fix teh tests Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/compiler/dart2js/serialization/model_test_helper.dart

diff --git a/tests/compiler/dart2js/serialization/model_test_helper.dart b/tests/compiler/dart2js/serialization/model_test_helper.dart

index 959248b615e06997137be71aa4272c0838799182..22dd013d2ffa3667db7f408a20d48cfc4cc7d014 100644

--- a/tests/compiler/dart2js/serialization/model_test_helper.dart

+++ b/tests/compiler/dart2js/serialization/model_test_helper.dart

@@ -162,10 +162,10 @@ void checkElements(

(element1.isField && element1.isInstanceMember)) {

AstElement astElement1 = element1;

Siggi Cherem (dart-lang) 2017/06/05 22:27:04 you might be able to delete these locals now.

Emily Fortuna 2017/06/05 22:30:21 oh good point! Thanks.

AstElement astElement2 = element2;

- ClosureClassMap closureData1 = compiler1.closureToClassMapper

- .getClosureToClassMapping(astElement1.resolvedAst);

- ClosureClassMap closureData2 = compiler2.closureToClassMapper

- .getClosureToClassMapping(astElement2.resolvedAst);

+ ClosureClassMap closureData1 =

+ compiler1.closureToClassMapper.getClosureToClassMapping(element1);

+ ClosureClassMap closureData2 =

+ compiler2.closureToClassMapper.getClosureToClassMapping(element2);

checkElementIdentities(

closureData1,

« no previous file with comments | « pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart ('k') | no next file » | no next file with comments »