Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2920223011: [context] fix treatment of None in env. (Closed)

Created:
3 years, 6 months ago by iannucci
Modified:
3 years, 6 months ago
Reviewers:
dnj
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[context] fix treatment of None in env. https://codereview.chromium.org/2925453002 introduced a bug where setting an envvar to None would set its value to "" instead of removing it from the environment. This CL restores that behavior. R=dnj@chromium.org BUG= Review-Url: https://codereview.chromium.org/2920223011 Committed: https://github.com/luci/recipes-py/commit/c916898b8189866a0bf43fe15c800e4fe6d4a19e

Patch Set 1 #

Patch Set 2 : really fix it #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -11 lines) Patch
M recipe_modules/context/api.py View 1 4 chunks +18 lines, -10 lines 0 comments Download
M recipe_modules/context/tests/env.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M recipe_modules/context/tests/env.expected/basic.json View 1 1 chunk +11 lines, -0 lines 0 comments Download
M recipe_modules/python/examples/full.expected/basic.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (12 generated)
iannucci
3 years, 6 months ago (2017-06-08 00:44:43 UTC) #1
dnj
lgtm
3 years, 6 months ago (2017-06-08 01:02:58 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2920223011/20001
3 years, 6 months ago (2017-06-08 01:03:01 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 01:06:07 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/recipes-py/commit/c916898b8189866a0bf43fe15c800e4fe6d...

Powered by Google App Engine
This is Rietveld 408576698