recipe_modules/context/tests/env.expected/basic.json - Issue 2920223011: [context] fix treatment of None in env.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: recipe_modules/context/tests/env.expected/basic.json

Issue 2920223011: [context] fix treatment of None in env. (Closed)

Patch Set: really fix it Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 [	1 [

2 {	2 {

3 "cmd": [	3 "cmd": [

4 "echo",	4 "echo",

5 "hello"	5 "hello"

6 ],	6 ],

7 "name": "no env"	7 "name": "no env"

8 },	8 },

9 {	9 {

10 "cmd": [	10 "cmd": [

(...skipping 54 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
65 "bash",	65 "bash",

66 "-c",	66 "-c",

67 "echo $FOO"	67 "echo $FOO"

68 ],	68 ],

69 "env": {	69 "env": {

70 "FOO": "[START_DIR]/shirt"	70 "FOO": "[START_DIR]/shirt"

71 },	71 },

72 "name": "env with default value"	72 "name": "env with default value"

73 },	73 },

74 {	74 {

	75 "cmd": [

	76 "bash",

	77 "-c",

	78 "set"

	79 ],

	80 "env": {

	81 "PYTHONPATH": null

	82 },

	83 "name": "drop PYTHONPATH"

	84 },

	85 {

75 "name": "$result",	86 "name": "$result",

76 "recipe_result": null,	87 "recipe_result": null,

77 "status_code": 0	88 "status_code": 0

78 }	89 }

79 ]	90 ]

OLD	NEW