Rename RareInheritedData::variables and RareNonInheritedData::variables.

Rename RareInheritedData::variables and RareNonInheritedData::variables.

When we generate fields in ComputedStyleBase, the name of the fields
must be distinct. Sometimes, existing handwritten data members share
the same name because they are stored on different groups. This may not
be true when they become generated. Hence, we have to rename these
members with a distinct name.

This patch renames:
- StyleRareInheritedData::variables_ -> inherited_variables_
- StyleRareNonInheritedData::variables_ -> non_inherited_variables_

There are no changes in behaviour.

BUG=628043
Review-Url: https://codereview.chromium.org/2920133003
Cr-Commit-Position: refs/heads/master@{#477098}
Committed: https://chromium.googlesource.com/chromium/src/+/f7b7f0ee69149ccc0bf5a903d6086b114626dda8

[shend, 2017-06-05 07:17:23]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-05 07:17:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shend, 2017-06-05 07:25:08]

shend@chromium.org changed reviewers:
+ nainar@chromium.org

[shend, 2017-06-05 07:25:09]

Hi Naina, PTAL

[shend, 2017-06-05 08:01:16]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-05 08:01:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-05 11:54:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-05 11:54:42]

Dry run: This issue passed the CQ dry run.

[nainar, 2017-06-05 16:28:17]

lgtm 

"Sometimes, existing handwritten data members share the same name because they
are stored on the same group." -> "Sometimes, existing handwritten data members
share the same name because they are stored on different groups."

[shend, 2017-06-05 22:12:50]

Description was changed from

==========
Rename RareInheritedData::variables and RareNonInheritedData::variables.

When we generate fields in ComputedStyleBase, the name of the fields
must be distinct. Sometimes, existing handwritten data members share
the same name because they are stored on the same group. This may not
be true when they become generated. Hence, we have to rename these
members with a distinct name.

This patch renames:
- StyleRareInheritedData::variables_ -> inherited_variables_
- StyleRareNonInheritedData::variables_ -> non_inherited_variables_

There are no changes in behaviour.

BUG=628043
==========

to

==========
Rename RareInheritedData::variables and RareNonInheritedData::variables.

When we generate fields in ComputedStyleBase, the name of the fields
must be distinct. Sometimes, existing handwritten data members share
the same name because they are stored on different groups. This may not
be true when they become generated. Hence, we have to rename these
members with a distinct name.

This patch renames:
- StyleRareInheritedData::variables_ -> inherited_variables_
- StyleRareNonInheritedData::variables_ -> non_inherited_variables_

There are no changes in behaviour.

BUG=628043
==========

[shend, 2017-06-05 22:13:03]

> "Sometimes, existing handwritten data members share the same name because they
are stored on the same group." -> "Sometimes, existing handwritten data members
share the same name because they are stored on different groups."

lol fixed

[shend, 2017-06-05 22:13:10]

The CQ bit was checked by shend@chromium.org

[commit-bot: I haz the power, 2017-06-05 22:14:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-05 22:18:45]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496700790059510,
"parent_rev": "200555e667f964ed2f057660039c072278d170ad", "commit_rev":
"0c9a637a82d6cbed7814adff37163a5c73f20cc4"}

[commit-bot: I haz the power, 2017-06-05 22:19:00]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496700790059510,
"parent_rev": "e70b0a6a828eff79932f293ccc4f90a27501fae2", "commit_rev":
"f7b7f0ee69149ccc0bf5a903d6086b114626dda8"}

[commit-bot: I haz the power, 2017-06-05 22:19:12]

Description was changed from

==========
Rename RareInheritedData::variables and RareNonInheritedData::variables.

When we generate fields in ComputedStyleBase, the name of the fields
must be distinct. Sometimes, existing handwritten data members share
the same name because they are stored on different groups. This may not
be true when they become generated. Hence, we have to rename these
members with a distinct name.

This patch renames:
- StyleRareInheritedData::variables_ -> inherited_variables_
- StyleRareNonInheritedData::variables_ -> non_inherited_variables_

There are no changes in behaviour.

BUG=628043
==========

to

==========
Rename RareInheritedData::variables and RareNonInheritedData::variables.

When we generate fields in ComputedStyleBase, the name of the fields
must be distinct. Sometimes, existing handwritten data members share
the same name because they are stored on different groups. This may not
be true when they become generated. Hence, we have to rename these
members with a distinct name.

This patch renames:
- StyleRareInheritedData::variables_ -> inherited_variables_
- StyleRareNonInheritedData::variables_ -> non_inherited_variables_

There are no changes in behaviour.

BUG=628043

Review-Url: https://codereview.chromium.org/2920133003
Cr-Commit-Position: refs/heads/master@{#477098}
Committed:
https://chromium.googlesource.com/chromium/src/+/f7b7f0ee69149ccc0bf5a903d608...
==========

[commit-bot: I haz the power, 2017-06-05 22:19:13]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f7b7f0ee69149ccc0bf5a903d608...