Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(102)

Issue 2920133003: Rename RareInheritedData::variables and RareNonInheritedData::variables. (Closed)

Created:
1 year, 6 months ago by shend
Modified:
1 year, 6 months ago
Reviewers:
nainar
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename RareInheritedData::variables and RareNonInheritedData::variables. When we generate fields in ComputedStyleBase, the name of the fields must be distinct. Sometimes, existing handwritten data members share the same name because they are stored on different groups. This may not be true when they become generated. Hence, we have to rename these members with a distinct name. This patch renames: - StyleRareInheritedData::variables_ -> inherited_variables_ - StyleRareNonInheritedData::variables_ -> non_inherited_variables_ There are no changes in behaviour. BUG=628043 Review-Url: https://codereview.chromium.org/2920133003 Cr-Commit-Position: refs/heads/master@{#477098} Committed: https://chromium.googlesource.com/chromium/src/+/f7b7f0ee69149ccc0bf5a903d6086b114626dda8

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5 View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleRareNonInheritedData.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleRareNonInheritedData.cpp View 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
shend
Hi Naina, PTAL
1 year, 6 months ago (2017-06-05 07:25:09 UTC) #4
nainar
lgtm "Sometimes, existing handwritten data members share the same name because they are stored on ...
1 year, 6 months ago (2017-06-05 16:28:17 UTC) #9
shend
> "Sometimes, existing handwritten data members share the same name because they are stored on ...
1 year, 6 months ago (2017-06-05 22:13:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2920133003/20001
1 year, 6 months ago (2017-06-05 22:14:00 UTC) #13
commit-bot: I haz the power
1 year, 6 months ago (2017-06-05 22:19:13 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f7b7f0ee69149ccc0bf5a903d608...

Powered by Google App Engine
This is Rietveld 408576698