Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2919903003: Ensure RemoteViewportIntersection rect persists across frame navigations (Closed)

Created:
3 years, 6 months ago by kenrb
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Ensure RemoteViewportIntersection rect persists across frame navigations To prevent excessive IPC messages, a parent frame of an OOPIF only updates its remote viewport intersection rect when the intersection changes. However, a frame can navigate without the parent frame being aware of it, in which case the rect is lost without being resent. To address that problem, this CL caches the rect on CrossProcessFrameConnector in the browser process, and sends it to the renderer whenever RenderWidgetHostImpl::SendScreenRects() is called. This CL also moves the rect's storage in Blink from LocalFrameView to LocalFrame so that it persists across same-process navigations. BUG=720342 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2910023002 Cr-Original-Commit-Position: refs/heads/master@{#475756} Review-Url: https://codereview.chromium.org/2919903003 . Cr-Commit-Position: refs/branch-heads/3112@{#119} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/3978c4d1047d5a2559a6b85de3804790872e35d9

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
kenrb
3 years, 6 months ago (2017-06-02 16:24:14 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3978c4d1047d5a2559a6b85de3804790872e35d9.

Powered by Google App Engine
This is Rietveld 408576698