Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Side by Side Diff: third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

Issue 2919903003: Ensure RemoteViewportIntersection rect persists across frame navigations (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/frame/LocalFrame.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 750 matching lines...) Expand 10 before | Expand all | Expand 10 after
761 761
762 bounds.Swap(result); 762 bounds.Swap(result);
763 return true; 763 return true;
764 } 764 }
765 765
766 void WebFrameWidgetImpl::SetRemoteViewportIntersection( 766 void WebFrameWidgetImpl::SetRemoteViewportIntersection(
767 const WebRect& viewport_intersection) { 767 const WebRect& viewport_intersection) {
768 // Remote viewports are only applicable to local frames with remote ancestors. 768 // Remote viewports are only applicable to local frames with remote ancestors.
769 DCHECK(local_root_->Parent() && local_root_->Parent()->IsWebRemoteFrame()); 769 DCHECK(local_root_->Parent() && local_root_->Parent()->IsWebRemoteFrame());
770 770
771 if (local_root_->GetFrameView()) { 771 if (local_root_->GetFrame()) {
772 local_root_->GetFrameView()->SetViewportIntersectionFromParent( 772 local_root_->GetFrame()->SetViewportIntersectionFromParent(
773 viewport_intersection); 773 viewport_intersection);
774 } 774 }
775 } 775 }
776 776
777 void WebFrameWidgetImpl::HandleMouseLeave(LocalFrame& main_frame, 777 void WebFrameWidgetImpl::HandleMouseLeave(LocalFrame& main_frame,
778 const WebMouseEvent& event) { 778 const WebMouseEvent& event) {
779 // FIXME: WebWidget doesn't have the method below. 779 // FIXME: WebWidget doesn't have the method below.
780 // m_client->setMouseOverURL(WebURL()); 780 // m_client->setMouseOverURL(WebURL());
781 PageWidgetEventHandler::HandleMouseLeave(main_frame, event); 781 PageWidgetEventHandler::HandleMouseLeave(main_frame, event);
782 } 782 }
(...skipping 414 matching lines...) Expand 10 before | Expand all | Expand 10 after
1197 : nullptr; 1197 : nullptr;
1198 } 1198 }
1199 1199
1200 LocalFrame* WebFrameWidgetImpl::FocusedLocalFrameAvailableForIme() const { 1200 LocalFrame* WebFrameWidgetImpl::FocusedLocalFrameAvailableForIme() const {
1201 if (!ime_accept_events_) 1201 if (!ime_accept_events_)
1202 return nullptr; 1202 return nullptr;
1203 return FocusedLocalFrameInWidget(); 1203 return FocusedLocalFrameInWidget();
1204 } 1204 }
1205 1205
1206 } // namespace blink 1206 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/frame/LocalFrame.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698