Remove references to ui/views/layout/layout_constants.h

Remove references to ui/views/layout/layout_constants.h

Replace references to constants in ui/views/layout/layout_constants.h with their
equivalents using ChromeLayoutProvider.

BUG=691897
Review-Url: https://codereview.chromium.org/2919903002
Cr-Commit-Position: refs/heads/master@{#476520}
Committed: https://chromium.googlesource.com/chromium/src/+/127b114a4ab9474637dfbe111fac9fadbd7d4b0c

[ananta, 2017-06-01 23:26:32]

ananta@chromium.org changed reviewers:
+ pkasting@chromium.org

[ananta, 2017-06-01 23:28:24]

The CQ bit was checked by ananta@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-01 23:29:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 23:48:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 23:48:07]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ananta, 2017-06-01 23:59:42]

The CQ bit was checked by ananta@chromium.org to run a CQ dry run

[Peter Kasting, 2017-06-01 23:59:56]

LGTM

https://codereview.chromium.org/2919903002/diff/1/chrome/browser/chromeos/DEPS
File chrome/browser/chromeos/DEPS (right):

https://codereview.chromium.org/2919903002/diff/1/chrome/browser/chromeos/DEP...
chrome/browser/chromeos/DEPS:6:
"+chrome/browser/ui/views/harmony/chrome_layout_provider.h",
Nit: Add TODO describing how you intend to rectify this (if it won't be
immediate, then file a bug on the reorg plan and link to that)

https://codereview.chromium.org/2919903002/diff/1/chrome/browser/chromeos/att...
File chrome/browser/chromeos/attestation/platform_verification_dialog.cc
(right):

https://codereview.chromium.org/2919903002/diff/1/chrome/browser/chromeos/att...
chrome/browser/chromeos/attestation/platform_verification_dialog.cc:81: 
Nit: Blank line unnecessary

https://codereview.chromium.org/2919903002/diff/1/chrome/browser/chromeos/pow...
File chrome/browser/chromeos/power/idle_action_warning_dialog_view.cc (right):

https://codereview.chromium.org/2919903002/diff/1/chrome/browser/chromeos/pow...
chrome/browser/chromeos/power/idle_action_warning_dialog_view.cc:70:
views::CreateEmptyBorder(dialog_insets.top(), dialog_insets.left(),
Nit: Just pass |dialog_insets|.  You could even inline it here if you want.

https://codereview.chromium.org/2919903002/diff/1/chrome/browser/chromeos/pro...
File chrome/browser/chromeos/profiles/multiprofiles_intro_dialog.cc (right):

https://codereview.chromium.org/2919903002/diff/1/chrome/browser/chromeos/pro...
chrome/browser/chromeos/profiles/multiprofiles_intro_dialog.cc:112:
SetBorder(views::CreateEmptyBorder(dialog_insets.top(), dialog_insets.left(),
This looks like INSETS_DIALOG_TITLE.

[commit-bot: I haz the power, 2017-06-02 00:00:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ananta, 2017-06-02 00:16:32]

The CQ bit was checked by ananta@chromium.org to run a CQ dry run

[ananta, 2017-06-02 00:16:37]

https://codereview.chromium.org/2919903002/diff/1/chrome/browser/chromeos/DEPS
File chrome/browser/chromeos/DEPS (right):

https://codereview.chromium.org/2919903002/diff/1/chrome/browser/chromeos/DEP...
chrome/browser/chromeos/DEPS:6:
"+chrome/browser/ui/views/harmony/chrome_layout_provider.h",
On 2017/06/01 23:59:56, Peter Kasting wrote:
> Nit: Add TODO describing how you intend to rectify this (if it won't be
> immediate, then file a bug on the reorg plan and link to that)

Done.

https://codereview.chromium.org/2919903002/diff/1/chrome/browser/chromeos/att...
File chrome/browser/chromeos/attestation/platform_verification_dialog.cc
(right):

https://codereview.chromium.org/2919903002/diff/1/chrome/browser/chromeos/att...
chrome/browser/chromeos/attestation/platform_verification_dialog.cc:81: 
On 2017/06/01 23:59:56, Peter Kasting wrote:
> Nit: Blank line unnecessary

Done.

https://codereview.chromium.org/2919903002/diff/1/chrome/browser/chromeos/pow...
File chrome/browser/chromeos/power/idle_action_warning_dialog_view.cc (right):

https://codereview.chromium.org/2919903002/diff/1/chrome/browser/chromeos/pow...
chrome/browser/chromeos/power/idle_action_warning_dialog_view.cc:70:
views::CreateEmptyBorder(dialog_insets.top(), dialog_insets.left(),
On 2017/06/01 23:59:56, Peter Kasting wrote:
> Nit: Just pass |dialog_insets|.  You could even inline it here if you want.

Thanks done.

https://codereview.chromium.org/2919903002/diff/1/chrome/browser/chromeos/pro...
File chrome/browser/chromeos/profiles/multiprofiles_intro_dialog.cc (right):

https://codereview.chromium.org/2919903002/diff/1/chrome/browser/chromeos/pro...
chrome/browser/chromeos/profiles/multiprofiles_intro_dialog.cc:112:
SetBorder(views::CreateEmptyBorder(dialog_insets.top(), dialog_insets.left(),
On 2017/06/01 23:59:56, Peter Kasting wrote:
> This looks like INSETS_DIALOG_TITLE.

Done.

[commit-bot: I haz the power, 2017-06-02 00:16:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 00:40:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 00:40:48]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ananta, 2017-06-02 01:00:56]

The CQ bit was checked by ananta@chromium.org

[ananta, 2017-06-02 01:00:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2919903002/#ps80001
(title: "presubmit")

[commit-bot: I haz the power, 2017-06-02 01:01:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 01:12:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 01:12:45]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[ananta, 2017-06-02 01:17:24]

Description was changed from

==========
Remove references to ui/views/layout/layout_constants.h

Replace references to constants in ui/views/layout/layout_constants.h with their
equivalents using ChromeLayoutProvider.

BUG=691897
==========

to

==========
Remove references to ui/views/layout/layout_constants.h

Replace references to constants in ui/views/layout/layout_constants.h with their
equivalents using ChromeLayoutProvider.

BUG=691897
==========

[ananta, 2017-06-02 01:17:24]

ananta@chromium.org changed reviewers:
+ oshima@chromium.org

[ananta, 2017-06-02 01:17:43]

+oshima for chromeos owners

[oshima, 2017-06-02 01:20:38]

On 2017/06/02 01:17:43, ananta wrote:
> +oshima for chromeos owners

lgtm

[ananta, 2017-06-02 01:26:08]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2017-06-02 01:26:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 02:00:05]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1496366768990550,
"parent_rev": "d9c939597cd5b8b2af091441674b526cd1cee52e", "commit_rev":
"127b114a4ab9474637dfbe111fac9fadbd7d4b0c"}

[commit-bot: I haz the power, 2017-06-02 02:00:13]

Description was changed from

==========
Remove references to ui/views/layout/layout_constants.h

Replace references to constants in ui/views/layout/layout_constants.h with their
equivalents using ChromeLayoutProvider.

BUG=691897
==========

to

==========
Remove references to ui/views/layout/layout_constants.h

Replace references to constants in ui/views/layout/layout_constants.h with their
equivalents using ChromeLayoutProvider.

BUG=691897

Review-Url: https://codereview.chromium.org/2919903002
Cr-Commit-Position: refs/heads/master@{#476520}
Committed:
https://chromium.googlesource.com/chromium/src/+/127b114a4ab9474637dfbe111fac...
==========

[commit-bot: I haz the power, 2017-06-02 02:00:15]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/127b114a4ab9474637dfbe111fac...

[sky, 2017-06-02 17:56:14]

sky@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2017-06-02 17:56:15]

https://codereview.chromium.org/2919903002/diff/80001/chrome/browser/chromeos...
File chrome/browser/chromeos/DEPS (right):

https://codereview.chromium.org/2919903002/diff/80001/chrome/browser/chromeos...
chrome/browser/chromeos/DEPS:6: #TODO(ananta): Remove this when we move files
which display UI in
Space after '#'