Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1015)

Side by Side Diff: chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc

Issue 2919903002: Remove references to ui/views/layout/layout_constants.h (Closed)
Patch Set: presubmit Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/login/ui/simple_web_view_dialog.h" 5 #include "chrome/browser/chromeos/login/ui/simple_web_view_dialog.h"
6 6
7 #include "ash/public/cpp/shell_window_ids.h" 7 #include "ash/public/cpp/shell_window_ids.h"
8 #include "ash/shell.h" 8 #include "ash/shell.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/message_loop/message_loop.h" 10 #include "base/message_loop/message_loop.h"
11 #include "base/strings/utf_string_conversions.h" 11 #include "base/strings/utf_string_conversions.h"
12 #include "chrome/app/chrome_command_ids.h" 12 #include "chrome/app/chrome_command_ids.h"
13 #include "chrome/browser/chromeos/login/helper.h" 13 #include "chrome/browser/chromeos/login/helper.h"
14 #include "chrome/browser/chromeos/login/ui/captive_portal_window_proxy.h" 14 #include "chrome/browser/chromeos/login/ui/captive_portal_window_proxy.h"
15 #include "chrome/browser/command_updater.h" 15 #include "chrome/browser/command_updater.h"
16 #include "chrome/browser/password_manager/chrome_password_manager_client.h" 16 #include "chrome/browser/password_manager/chrome_password_manager_client.h"
17 #include "chrome/browser/profiles/profile.h" 17 #include "chrome/browser/profiles/profile.h"
18 #include "chrome/browser/ssl/security_state_tab_helper.h" 18 #include "chrome/browser/ssl/security_state_tab_helper.h"
19 #include "chrome/browser/ui/autofill/chrome_autofill_client.h" 19 #include "chrome/browser/ui/autofill/chrome_autofill_client.h"
20 #include "chrome/browser/ui/browser.h" 20 #include "chrome/browser/ui/browser.h"
21 #include "chrome/browser/ui/content_settings/content_setting_bubble_model_delega te.h" 21 #include "chrome/browser/ui/content_settings/content_setting_bubble_model_delega te.h"
22 #include "chrome/browser/ui/view_ids.h" 22 #include "chrome/browser/ui/view_ids.h"
23 #include "chrome/browser/ui/views/harmony/chrome_layout_provider.h"
23 #include "chrome/browser/ui/views/toolbar/reload_button.h" 24 #include "chrome/browser/ui/views/toolbar/reload_button.h"
24 #include "chrome/grit/generated_resources.h" 25 #include "chrome/grit/generated_resources.h"
25 #include "chrome/grit/theme_resources.h" 26 #include "chrome/grit/theme_resources.h"
26 #include "components/password_manager/core/browser/password_manager.h" 27 #include "components/password_manager/core/browser/password_manager.h"
27 #include "components/strings/grit/components_strings.h" 28 #include "components/strings/grit/components_strings.h"
28 #include "components/toolbar/toolbar_model_impl.h" 29 #include "components/toolbar/toolbar_model_impl.h"
29 #include "content/public/browser/navigation_controller.h" 30 #include "content/public/browser/navigation_controller.h"
30 #include "content/public/browser/navigation_entry.h" 31 #include "content/public/browser/navigation_entry.h"
31 #include "content/public/browser/web_contents.h" 32 #include "content/public/browser/web_contents.h"
32 #include "content/public/common/content_constants.h" 33 #include "content/public/common/content_constants.h"
33 #include "ipc/ipc_message.h" 34 #include "ipc/ipc_message.h"
34 #include "ui/base/l10n/l10n_util.h" 35 #include "ui/base/l10n/l10n_util.h"
35 #include "ui/base/theme_provider.h" 36 #include "ui/base/theme_provider.h"
36 #include "ui/views/background.h" 37 #include "ui/views/background.h"
37 #include "ui/views/controls/webview/webview.h" 38 #include "ui/views/controls/webview/webview.h"
38 #include "ui/views/layout/grid_layout.h" 39 #include "ui/views/layout/grid_layout.h"
39 #include "ui/views/layout/layout_constants.h"
40 #include "ui/views/view.h" 40 #include "ui/views/view.h"
41 #include "ui/views/widget/widget.h" 41 #include "ui/views/widget/widget.h"
42 42
43 using content::WebContents; 43 using content::WebContents;
44 using views::GridLayout; 44 using views::GridLayout;
45 45
46 namespace { 46 namespace {
47 47
48 const int kLocationBarHeight = 35; 48 const int kLocationBarHeight = 35;
49 49
(...skipping 13 matching lines...) Expand all
63 63
64 ~ToolbarRowView() override {} 64 ~ToolbarRowView() override {}
65 65
66 void Init(views::View* back, 66 void Init(views::View* back,
67 views::View* forward, 67 views::View* forward,
68 views::View* reload, 68 views::View* reload,
69 views::View* location_bar) { 69 views::View* location_bar) {
70 GridLayout* layout = new GridLayout(this); 70 GridLayout* layout = new GridLayout(this);
71 SetLayoutManager(layout); 71 SetLayoutManager(layout);
72 72
73 const int related_horizontal_spacing =
74 ChromeLayoutProvider::Get()->GetDistanceMetric(
75 views::DISTANCE_RELATED_CONTROL_HORIZONTAL);
73 // Back button. 76 // Back button.
74 views::ColumnSet* column_set = layout->AddColumnSet(0); 77 views::ColumnSet* column_set = layout->AddColumnSet(0);
75 column_set->AddColumn(GridLayout::CENTER, GridLayout::CENTER, 0, 78 column_set->AddColumn(GridLayout::CENTER, GridLayout::CENTER, 0,
76 GridLayout::USE_PREF, 0, 0); 79 GridLayout::USE_PREF, 0, 0);
77 column_set->AddPaddingColumn(0, views::kRelatedControlHorizontalSpacing); 80 column_set->AddPaddingColumn(0, related_horizontal_spacing);
78 // Forward button. 81 // Forward button.
79 column_set->AddColumn(GridLayout::CENTER, GridLayout::CENTER, 0, 82 column_set->AddColumn(GridLayout::CENTER, GridLayout::CENTER, 0,
80 GridLayout::USE_PREF, 0, 0); 83 GridLayout::USE_PREF, 0, 0);
81 column_set->AddPaddingColumn(0, views::kRelatedControlHorizontalSpacing); 84 column_set->AddPaddingColumn(0, related_horizontal_spacing);
82 // Reload button. 85 // Reload button.
83 column_set->AddColumn(GridLayout::CENTER, GridLayout::CENTER, 0, 86 column_set->AddColumn(GridLayout::CENTER, GridLayout::CENTER, 0,
84 GridLayout::USE_PREF, 0, 0); 87 GridLayout::USE_PREF, 0, 0);
85 column_set->AddPaddingColumn(0, views::kRelatedControlHorizontalSpacing); 88 column_set->AddPaddingColumn(0, related_horizontal_spacing);
86 // Location bar. 89 // Location bar.
87 column_set->AddColumn(GridLayout::FILL, GridLayout::CENTER, 1, 90 column_set->AddColumn(GridLayout::FILL, GridLayout::CENTER, 1,
88 GridLayout::FIXED, kLocationBarHeight, 0); 91 GridLayout::FIXED, kLocationBarHeight, 0);
89 column_set->AddPaddingColumn(0, views::kRelatedControlHorizontalSpacing); 92 column_set->AddPaddingColumn(0, related_horizontal_spacing);
90 93
91 layout->StartRow(0, 0); 94 layout->StartRow(0, 0);
92 layout->AddView(back); 95 layout->AddView(back);
93 layout->AddView(forward); 96 layout->AddView(forward);
94 layout->AddView(reload); 97 layout->AddView(reload);
95 layout->AddView(location_bar); 98 layout->AddView(location_bar);
96 } 99 }
97 100
98 private: 101 private:
99 DISALLOW_COPY_AND_ASSIGN(ToolbarRowView); 102 DISALLOW_COPY_AND_ASSIGN(ToolbarRowView);
(...skipping 270 matching lines...) Expand 10 before | Expand all | Expand 10 after
370 373
371 void SimpleWebViewDialog::UpdateReload(bool is_loading, bool force) { 374 void SimpleWebViewDialog::UpdateReload(bool is_loading, bool force) {
372 if (reload_) { 375 if (reload_) {
373 reload_->ChangeMode( 376 reload_->ChangeMode(
374 is_loading ? ReloadButton::MODE_STOP : ReloadButton::MODE_RELOAD, 377 is_loading ? ReloadButton::MODE_STOP : ReloadButton::MODE_RELOAD,
375 force); 378 force);
376 } 379 }
377 } 380 }
378 381
379 } // namespace chromeos 382 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698