Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2919663002: MD Settings: change how valid origins are checked and tested (Closed)

Created:
3 years, 6 months ago by Dan Beam
Modified:
3 years, 6 months ago
Reviewers:
dpapad
CC:
chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: change how valid origins are checked and tested R=dpapad@chromium.org BUG=727449 Review-Url: https://codereview.chromium.org/2919663002 Cr-Commit-Position: refs/heads/master@{#476450} Committed: https://chromium.googlesource.com/chromium/src/+/a58bf8c9220bff80d68a92f3d6b3f53fb76c4173

Patch Set 1 : asdf #

Patch Set 2 : _unittest.cc #

Patch Set 3 : merge #

Patch Set 4 : move md_settings_ui_unittest.cc in chrome/test/BUILD.gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -27 lines) Patch
M chrome/browser/ui/webui/settings/md_settings_ui.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_ui.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_ui_browsertest.cc View 1 2 3 chunks +0 lines, -25 lines 0 comments Download
A chrome/browser/ui/webui/settings/md_settings_ui_unittest.cc View 1 1 chunk +20 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 24 (18 generated)
Dan Beam
3 years, 6 months ago (2017-05-31 22:49:35 UTC) #2
dpapad
lgtm
3 years, 6 months ago (2017-05-31 22:55:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2919663002/60001
3 years, 6 months ago (2017-05-31 22:59:01 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/280074) android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 6 months ago (2017-05-31 23:35:51 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2919663002/80001
3 years, 6 months ago (2017-06-01 22:04:12 UTC) #21
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 22:09:53 UTC) #24
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/a58bf8c9220bff80d68a92f3d6b3...

Powered by Google App Engine
This is Rietveld 408576698