chrome/browser/ui/webui/settings/md_settings_ui_unittest.cc - Issue 2919663002: MD Settings: change how valid origins are checked and tested

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/webui/settings/md_settings_ui_unittest.cc

Issue 2919663002: MD Settings: change how valid origins are checked and tested (Closed)

Patch Set: move md_settings_ui_unittest.cc in chrome/test/BUILD.gn Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "chrome/browser/ui/webui/settings/md_settings_ui.h"

	6

	7 #include "chrome/common/url_constants.h"

	8 #include "content/public/common/url_constants.h"

	9 #include "testing/gtest/include/gtest/gtest.h"

	10 #include "url/gurl.h"

	11

	12 TEST(MdSettingsUITest, IsValidOrigin) {

	13 EXPECT_TRUE(settings::IsValidOrigin(GURL(chrome::kChromeUISettingsURL)));

	14 EXPECT_TRUE(settings::IsValidOrigin(GURL(chrome::kChromeUIMdSettingsURL)));

	15

	16 EXPECT_FALSE(settings::IsValidOrigin(GURL("http://evil.com")));

	17 EXPECT_FALSE(settings::IsValidOrigin(GURL("https://google.com")));

	18 EXPECT_FALSE(settings::IsValidOrigin(GURL(chrome::kChromeUINewTabURL)));

	19 EXPECT_FALSE(settings::IsValidOrigin(GURL(chrome::kChromeUIHistoryURL)));

	20 }

OLD	NEW