[WPT] Add automated manual test for InputEvent typing

[WPT] Add automated manual test for InputEvent typing

Passed on Chrome and Safari.

BUG=652439
Review-Url: https://codereview.chromium.org/2919603002
Cr-Commit-Position: refs/heads/master@{#476377}
Committed: https://chromium.googlesource.com/chromium/src/+/ff45c14fe5518b3c732c5e797118f9c0e0a69cf8

[chongz, 2017-05-31 20:24:01]

Description was changed from

==========
Add automated test for inputevent typing

BUG=
==========

to

==========
[Automation] Add automated manual test for inputevent typing

BUG=652439
==========

[chongz, 2017-05-31 20:27:36]

Description was changed from

==========
[Automation] Add automated manual test for inputevent typing

BUG=652439
==========

to

==========
Add automated manual test for inputevent typing

BUG=652439
==========

[chongz, 2017-05-31 20:27:57]

Description was changed from

==========
Add automated manual test for inputevent typing

BUG=652439
==========

to

==========
Add automated manual test for InputEvent typing

BUG=652439
==========

[chongz, 2017-05-31 20:28:24]

Description was changed from

==========
Add automated manual test for InputEvent typing

BUG=652439
==========

to

==========
[WPT] Add automated manual test for InputEvent typing

BUG=652439
==========

[chongz, 2017-05-31 20:28:45]

chongz@chromium.org changed reviewers:
+ foolip@chromium.org

[chongz, 2017-05-31 20:28:46]

foolip@ PTAL, thanks!

[foolip, 2017-06-01 13:54:21]

lgtm % nits

https://codereview.chromium.org/2919603002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/input-events/input-events-typing-data-manual.html
(right):

https://codereview.chromium.org/2919603002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/input-events/input-events-typing-data-manual.html:27:
['plain', 'rich'].forEach(targetId => {
Optional nit: I like to use `for (x of [...])` in cases like this where the test
already depends on ES6 features like let/const.

https://codereview.chromium.org/2919603002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/input-events/input-events-typing-data-manual.html:32:
if (eventCounter >= expectedResult.length)
nit: nothing that happens after the t.done() call matters, so the > bit isn't
necessary.

https://codereview.chromium.org/2919603002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt_automation/input-events/inputevent_common_input.js
(right):

https://codereview.chromium.org/2919603002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt_automation/input-events/inputevent_common_input.js:14:
document.querySelector(selector).focus();
Can you add a comment about why both this and keyDown are wrapped as promises
even though they could be synchronous? For keyDown I suspect the answer is the
ability to convert into a WebDriver-backed API, but for focus() I don't know,
that doesn't require any special powers.

https://codereview.chromium.org/2919603002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt_automation/input-events/inputevent_common_input.js:23:
inputevent_automation.done();
optional nit: could make this
inject_input().then(inputevent_automation.step_func_done());

[chongz, 2017-06-01 15:34:13]

https://codereview.chromium.org/2919603002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/input-events/input-events-typing-data-manual.html
(right):

https://codereview.chromium.org/2919603002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/input-events/input-events-typing-data-manual.html:27:
['plain', 'rich'].forEach(targetId => {
On 2017/06/01 13:54:21, foolip wrote:
> Optional nit: I like to use `for (x of [...])` in cases like this where the
test
> already depends on ES6 features like let/const.

Done.

https://codereview.chromium.org/2919603002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/input-events/input-events-typing-data-manual.html:32:
if (eventCounter >= expectedResult.length)
On 2017/06/01 13:54:21, foolip wrote:
> nit: nothing that happens after the t.done() call matters, so the > bit isn't
> necessary.

Done.

https://codereview.chromium.org/2919603002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt_automation/input-events/inputevent_common_input.js
(right):

https://codereview.chromium.org/2919603002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt_automation/input-events/inputevent_common_input.js:14:
document.querySelector(selector).focus();
On 2017/06/01 13:54:21, foolip wrote:
> Can you add a comment about why both this and keyDown are wrapped as promises
> even though they could be synchronous? For keyDown I suspect the answer is the
> ability to convert into a WebDriver-backed API, but for focus() I don't know,
> that doesn't require any special powers.

Yes I was thinking if we are going to use WebDriver-backed API for keyDown(),
but you are right we don't need special power for focus().

Added comment and changed |focus() => focusAndKeyDown()|.

https://codereview.chromium.org/2919603002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt_automation/input-events/inputevent_common_input.js:23:
inputevent_automation.done();
On 2017/06/01 13:54:21, foolip wrote:
> optional nit: could make this
> inject_input().then(inputevent_automation.step_func_done());

Done.

[chongz, 2017-06-01 15:36:22]

Description was changed from

==========
[WPT] Add automated manual test for InputEvent typing

BUG=652439
==========

to

==========
[WPT] Add automated manual test for InputEvent typing

Passed on Chrome and Safari.

BUG=652439
==========

[foolip, 2017-06-01 17:14:18]

Still LGTM

[chongz, 2017-06-01 17:23:41]

The CQ bit was checked by chongz@chromium.org

[commit-bot: I haz the power, 2017-06-01 17:24:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 19:03:44]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496337821313280,
"parent_rev": "d2f0dd39eaacdd2184c8bd53bb9af5b768a56360", "commit_rev":
"ff45c14fe5518b3c732c5e797118f9c0e0a69cf8"}

[commit-bot: I haz the power, 2017-06-01 19:03:55]

Description was changed from

==========
[WPT] Add automated manual test for InputEvent typing

Passed on Chrome and Safari.

BUG=652439
==========

to

==========
[WPT] Add automated manual test for InputEvent typing

Passed on Chrome and Safari.

BUG=652439

Review-Url: https://codereview.chromium.org/2919603002
Cr-Commit-Position: refs/heads/master@{#476377}
Committed:
https://chromium.googlesource.com/chromium/src/+/ff45c14fe5518b3c732c5e797118...
==========

[commit-bot: I haz the power, 2017-06-01 19:03:56]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ff45c14fe5518b3c732c5e797118...