third_party/WebKit/LayoutTests/external/wpt/input-events/input-events-typing-data-manual.html - Issue 2919603002: [WPT] Add automated manual test for InputEvent typing

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/external/wpt/input-events/input-events-typing-data-manual.html

Issue 2919603002: [WPT] Add automated manual test for InputEvent typing (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/external/wpt_automation/input-events/input-events-typing-data-manual-automation.js » ('j') | third_party/WebKit/LayoutTests/external/wpt_automation/input-events/inputevent_common_input.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <meta charset="utf-8">

	3 <title>InputEvent have data when typing on textarea and contenteditable</title>

	4 <script src="/resources/testharness.js"></script>

	5 <script src="/resources/testharnessreport.js"></script>

	6 <p>To manually run this test, please follow the steps below:<br/>

	7 1. Focus the first box and press key 'a' and then 'b'.<br/>

	8 2. Focus the second box and press key 'c' and then 'd'.<br/>

	9 <br/>

	10 If a "PASS" result appears the test passes, otherwise it fails</p>

	11 <textarea id='plain'></textarea>

	12 <div id='rich' style='border-style: solid;' contenteditable></div>

	13 <script>

	14 async_test(t => {

	15 const expectedResult = [

	16 'plain-beforeinput-a',

	17 'plain-input-a',

	18 'plain-beforeinput-b',

	19 'plain-input-b',

	20 'rich-beforeinput-c',

	21 'rich-input-c',

	22 'rich-beforeinput-d',

	23 'rich-input-d',

	24 ];

	25 let eventCounter = 0;

	26

	27 ['plain', 'rich'].forEach(targetId => {
	foolip 2017/06/01 13:54:21 Optional nit: I like to use `for (x of [...])` in Optional nit: I like to use `for (x of [...])` in cases like this where the test already depends on ES6 features like let/const. chongz 2017/06/01 15:34:13 Done. Show quoted text On 2017/06/01 13:54:21, foolip wrote: > Optional nit: I like to use `for (x of [...])` in cases like this where the test > already depends on ES6 features like let/const. Done.
	28 ['beforeinput', 'input'].forEach(eventType => {

	29 document.getElementById(targetId).addEventListener(eventType, t.step _func(e => {

	30 assert_equals(`${targetId}-${eventType}-${e.data}`, expectedResu lt[eventCounter]);

	31 ++eventCounter;

	32 if (eventCounter >= expectedResult.length)
	foolip 2017/06/01 13:54:21 nit: nothing that happens after the t.done() call nit: nothing that happens after the t.done() call matters, so the > bit isn't necessary. chongz 2017/06/01 15:34:13 Done. Show quoted text On 2017/06/01 13:54:21, foolip wrote: > nit: nothing that happens after the t.done() call matters, so the > bit isn't > necessary. Done.
	33 t.done();

	34 }));

	35 });

	36 });

	37 })

	38 </script>

OLD	NEW