chromeos: Move InputMethodUtil into //ui/base/ime/chromeos

chromeos: Move InputMethodUtil into //ui/base/ime/chromeos

For mustash we need to eliminate ash to chrome delegates. Moving this
class will allow it to be called directly from the system tray IME code
in ash, which will allow methods to be removed from SystemTrayDelegate.

Move the class into ui/base/ime/chromeos because that's where most of
the other utility code lives (like extension_ime_util).

* Move kBrailleIme constants to ui/base/ime/chromeos/extension_ime_util.h
* Fix input_method_whitelist.cc usage in BUILD rules for test targets
* Move Chrome OS IME strings to ui_chromeos_strings.grd

BUG=724305
TEST=ui_base_unittests, chrome unit_tests
TBR=rockot@chromium.org

Review-Url: https://codereview.chromium.org/2919583002
Cr-Commit-Position: refs/heads/master@{#476119}
Committed: https://chromium.googlesource.com/chromium/src/+/2d60f034473f06fd040407a2945f5b4a35b07df4

[James Cook, 2017-05-31 19:47:01]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-31 19:47:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2017-05-31 20:34:20]

Description was changed from

==========
chromeos: Move InputMethodUtil into //ui/base/ime/chromeos

For mustash we need to eliminate ash to chrome delegates. Moving this
class will allow it to be called directly from the system tray IME code
in ash, which will allow methods to be removed from SystemTrayDelegate.

* Move kBrailleIme constants to ui/base/ime/chromeos/extension_ime_util.h
* Fix input_method_whitelist.cc usage in BUILD rules for test targets
* Move IME strings to ui_chromeos_strings.grd

BUG=724305
TEST=ui_base_unittests, chrome unit_tests
==========

to

==========
chromeos: Move InputMethodUtil into //ui/base/ime/chromeos

For mustash we need to eliminate ash to chrome delegates. Moving this
class will allow it to be called directly from the system tray IME code
in ash, which will allow methods to be removed from SystemTrayDelegate.

Move the class into ui/base/ime/chromeos because that's where most of
the other utility code lives (like extension_ime_util).

* Move kBrailleIme constants to ui/base/ime/chromeos/extension_ime_util.h
* Fix input_method_whitelist.cc usage in BUILD rules for test targets
* Move Chrome OS IME strings to ui_chromeos_strings.grd

BUG=724305
TEST=ui_base_unittests, chrome unit_tests
==========

[James Cook, 2017-05-31 21:37:44]

jamescook@chromium.org changed reviewers:
+ shuchen@chromium.org, stevenjb@chromium.org

[James Cook, 2017-05-31 21:37:44]

shuchen, please take a look at everything.

stevenjb, please take a look at ui/chromeos (for strings).

The dependent CL https://codereview.chromium.org/2917683003 shows what I plan to
do next. (That CL is not ready for review yet.)

[commit-bot: I haz the power, 2017-05-31 21:53:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 21:53:25]

Dry run: This issue passed the CQ dry run.

[stevenjb, 2017-05-31 23:20:55]

The fact that we have ui/base/ime/chromeos and ui/chromeos/ime is wonky to say
the least, but cleanup for another day. In the meanwhile this seems fine. LGTM

[Shu Chen, 2017-06-01 00:27:12]

lgtm

[James Cook, 2017-06-01 00:46:32]

Description was changed from

==========
chromeos: Move InputMethodUtil into //ui/base/ime/chromeos

For mustash we need to eliminate ash to chrome delegates. Moving this
class will allow it to be called directly from the system tray IME code
in ash, which will allow methods to be removed from SystemTrayDelegate.

Move the class into ui/base/ime/chromeos because that's where most of
the other utility code lives (like extension_ime_util).

* Move kBrailleIme constants to ui/base/ime/chromeos/extension_ime_util.h
* Fix input_method_whitelist.cc usage in BUILD rules for test targets
* Move Chrome OS IME strings to ui_chromeos_strings.grd

BUG=724305
TEST=ui_base_unittests, chrome unit_tests
==========

to

==========
chromeos: Move InputMethodUtil into //ui/base/ime/chromeos

For mustash we need to eliminate ash to chrome delegates. Moving this
class will allow it to be called directly from the system tray IME code
in ash, which will allow methods to be removed from SystemTrayDelegate.

Move the class into ui/base/ime/chromeos because that's where most of
the other utility code lives (like extension_ime_util).

* Move kBrailleIme constants to ui/base/ime/chromeos/extension_ime_util.h
* Fix input_method_whitelist.cc usage in BUILD rules for test targets
* Move Chrome OS IME strings to ui_chromeos_strings.grd

BUG=724305
TEST=ui_base_unittests, chrome unit_tests
TBR=rockot@chromium.org
==========

[James Cook, 2017-06-01 00:47:04]

jamescook@chromium.org changed reviewers:
+ rockot@chromium.org

[James Cook, 2017-06-01 00:47:05]

Thanks for the reviews.

TBR rockot for removing some constants from
chrome/common/extensions/extensions_constants.h

[James Cook, 2017-06-01 00:47:15]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2017-06-01 00:48:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 00:55:24]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496278035213990, "parent_rev":
"9128b3b44a3141a7c67161e53b35d511e91aa282", "commit_rev":
"2d60f034473f06fd040407a2945f5b4a35b07df4"}

[commit-bot: I haz the power, 2017-06-01 00:55:38]

Description was changed from

==========
chromeos: Move InputMethodUtil into //ui/base/ime/chromeos

For mustash we need to eliminate ash to chrome delegates. Moving this
class will allow it to be called directly from the system tray IME code
in ash, which will allow methods to be removed from SystemTrayDelegate.

Move the class into ui/base/ime/chromeos because that's where most of
the other utility code lives (like extension_ime_util).

* Move kBrailleIme constants to ui/base/ime/chromeos/extension_ime_util.h
* Fix input_method_whitelist.cc usage in BUILD rules for test targets
* Move Chrome OS IME strings to ui_chromeos_strings.grd

BUG=724305
TEST=ui_base_unittests, chrome unit_tests
TBR=rockot@chromium.org
==========

to

==========
chromeos: Move InputMethodUtil into //ui/base/ime/chromeos

For mustash we need to eliminate ash to chrome delegates. Moving this
class will allow it to be called directly from the system tray IME code
in ash, which will allow methods to be removed from SystemTrayDelegate.

Move the class into ui/base/ime/chromeos because that's where most of
the other utility code lives (like extension_ime_util).

* Move kBrailleIme constants to ui/base/ime/chromeos/extension_ime_util.h
* Fix input_method_whitelist.cc usage in BUILD rules for test targets
* Move Chrome OS IME strings to ui_chromeos_strings.grd

BUG=724305
TEST=ui_base_unittests, chrome unit_tests
TBR=rockot@chromium.org

Review-Url: https://codereview.chromium.org/2919583002
Cr-Commit-Position: refs/heads/master@{#476119}
Committed:
https://chromium.googlesource.com/chromium/src/+/2d60f034473f06fd040407a2945f...
==========

[commit-bot: I haz the power, 2017-06-01 00:55:40]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2d60f034473f06fd040407a2945f...