Stop using TextIteratorBehavior in TextIteratorTextState

Stop using TextIteratorBehavior in TextIteratorTextState

This patch removes the dependency on TextIteratorBehavior from
TextIteratorTextState. After this patch, TextIteratorTextState becomes a
clean class doing exactly what it names suggests: storing the text state.
More specifically, it manages only:
- The current text
- The DOM position of the current text

BUG=721957
TEST=n/a; no behavioral change

Review-Url: https://codereview.chromium.org/2919433006
Cr-Commit-Position: refs/heads/master@{#476958}
Committed: https://chromium.googlesource.com/chromium/src/+/d4fd4e36421025fb37bc556408e6f30b8e94a55a

[Xiaocheng, 2017-06-02 01:57:13]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 01:57:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 03:51:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 03:51:17]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2017-06-05 03:52:40]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-05 03:52:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-06-05 03:56:16]

Description was changed from

==========
Stop using TextIteratorBehavior in TextIteratorTextState

BUG=
==========

to

==========
Stop using TextIteratorBehavior in TextIteratorTextState

This patch removes the dependency on TextIteratorBehavior from
TextIteratorTextState. After this patch, TextIteratorTextState becomes a
clean class doing exactly what it names suggests: storing the text state.
More specifically, it manages only:
- The current text
- The DOM position of the current text

BUG=721957
TEST=n/a; no behavioral change
==========

[Xiaocheng, 2017-06-05 03:56:24]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2017-06-05 03:56:25]

PTAL.

[yosin_UTC9, 2017-06-05 04:01:42]

lgtm w/ nits

Thanks for quick work!
I love this patch.

https://codereview.chromium.org/2919433006/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/iterators/TextIteratorTextState.cpp
(right):

https://codereview.chromium.org/2919433006/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/iterators/TextIteratorTextState.cpp:34:
TextIteratorTextState::TextIteratorTextState() {}
nit: s/{}/= default/

https://codereview.chromium.org/2919433006/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/iterators/TextIteratorTextState.h
(right):

https://codereview.chromium.org/2919433006/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/iterators/TextIteratorTextState.h:40:
explicit TextIteratorTextState();
nit: s/explicit//

[Xiaocheng, 2017-06-05 05:45:51]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[Xiaocheng, 2017-06-05 05:46:01]

Thanks for reviewing!

https://codereview.chromium.org/2919433006/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/iterators/TextIteratorTextState.cpp
(right):

https://codereview.chromium.org/2919433006/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/iterators/TextIteratorTextState.cpp:34:
TextIteratorTextState::TextIteratorTextState() {}
On 2017/06/05 at 04:01:41, yosin_UTC9 wrote:
> nit: s/{}/= default/

Done. Moved to .h file.

https://codereview.chromium.org/2919433006/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/iterators/TextIteratorTextState.h
(right):

https://codereview.chromium.org/2919433006/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/iterators/TextIteratorTextState.h:40:
explicit TextIteratorTextState();
On 2017/06/05 at 04:01:41, yosin_UTC9 wrote:
> nit: s/explicit//

Done.

[commit-bot: I haz the power, 2017-06-05 05:46:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-06-05 06:44:37]

The CQ bit was unchecked by xiaochengh@chromium.org

[Xiaocheng, 2017-06-05 06:44:39]

The CQ bit was checked by xiaochengh@chromium.org

[Xiaocheng, 2017-06-05 06:44:39]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2919433006/#ps60001
(title: "Sun Jun  4 22:44:20 PDT 2017")

[commit-bot: I haz the power, 2017-06-05 06:44:45]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-05 07:59:04]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1496645079252600,
"parent_rev": "8be7d37bae53e8224cbd4ca210d34b2b5580d7c8", "commit_rev":
"d4fd4e36421025fb37bc556408e6f30b8e94a55a"}

[commit-bot: I haz the power, 2017-06-05 07:59:14]

Description was changed from

==========
Stop using TextIteratorBehavior in TextIteratorTextState

This patch removes the dependency on TextIteratorBehavior from
TextIteratorTextState. After this patch, TextIteratorTextState becomes a
clean class doing exactly what it names suggests: storing the text state.
More specifically, it manages only:
- The current text
- The DOM position of the current text

BUG=721957
TEST=n/a; no behavioral change
==========

to

==========
Stop using TextIteratorBehavior in TextIteratorTextState

This patch removes the dependency on TextIteratorBehavior from
TextIteratorTextState. After this patch, TextIteratorTextState becomes a
clean class doing exactly what it names suggests: storing the text state.
More specifically, it manages only:
- The current text
- The DOM position of the current text

BUG=721957
TEST=n/a; no behavioral change

Review-Url: https://codereview.chromium.org/2919433006
Cr-Commit-Position: refs/heads/master@{#476958}
Committed:
https://chromium.googlesource.com/chromium/src/+/d4fd4e36421025fb37bc556408e6...
==========

[commit-bot: I haz the power, 2017-06-05 07:59:15]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/d4fd4e36421025fb37bc556408e6...