Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2925513002: Clean up includes in TextIteratorTextState.h/cpp (Closed)

Created:
3 years, 6 months ago by Xiaocheng
Modified:
3 years, 6 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up includes in TextIteratorTextState.h/cpp BUG=n/a Review-Url: https://codereview.chromium.org/2925513002 Cr-Commit-Position: refs/heads/master@{#477876} Committed: https://chromium.googlesource.com/chromium/src/+/54dd1f94d5fe8bbf9ae0df468a4e8224d970ddeb

Patch Set 1 #

Patch Set 2 : Sun Jun 4 23:00:31 PDT 2017 #

Patch Set 3 : Mon Jun 5 12:14:41 PDT 2017 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/core/editing/iterators/TextIteratorTextState.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/TextIteratorTextState.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
Xiaocheng
PTAL.
3 years, 6 months ago (2017-06-05 06:01:29 UTC) #5
yosin_UTC9
Compilation failed... (T_T) FAILED: obj/third_party/WebKit/Source/web/web/WebSubstringUtil.o ../../third_party/WebKit/Source/web/mac/WebSubstringUtil.mm:126:24: error: variable has incomplete type 'blink::ForwardsTextBuffer' ForwardsTextBuffer characters; ^ ...
3 years, 6 months ago (2017-06-05 06:56:08 UTC) #9
Xiaocheng
On 2017/06/05 at 06:56:08, yosin wrote: > Compilation failed... (T_T) > > FAILED: obj/third_party/WebKit/Source/web/web/WebSubstringUtil.o > ...
3 years, 6 months ago (2017-06-05 19:08:31 UTC) #10
Xiaocheng
Ping...
3 years, 6 months ago (2017-06-07 17:58:28 UTC) #15
yosin_UTC9
lgtm
3 years, 6 months ago (2017-06-08 01:21:50 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2925513002/40001
3 years, 6 months ago (2017-06-08 01:22:10 UTC) #18
commit-bot: I haz the power
3 years, 6 months ago (2017-06-08 03:58:41 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/54dd1f94d5fe8bbf9ae0df468a4e...

Powered by Google App Engine
This is Rietveld 408576698