Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2919393002: [merge to m60] cros: Do not cache |root_window| in ScreenRotationAnimator. (Closed)

Created:
3 years, 6 months ago by Qiang(Joe) Xu
Modified:
3 years, 6 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

[merge to m60] cros: Do not cache |root_window| in ScreenRotationAnimator. Merget to m60 on behalf of wutao When removing a display the |root_window| might change. The cache does not work in this situation. TBR=oshima@chromium.org BUG=728029 TEST=manual and ScreenRotationAnimatorSmoothAnimationTest.* Review-Url: https://codereview.chromium.org/2910413002 Cr-Original-Commit-Position: refs/heads/master@{#476723} Review-Url: https://codereview.chromium.org/2919393002 . Cr-Commit-Position: refs/branch-heads/3112@{#161} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/6b279cbf120d6f980b40633aa6cb76d8e6af1125

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -130 lines) Patch
M ash/display/display_configuration_controller.h View 2 chunks +4 lines, -11 lines 0 comments Download
M ash/display/display_configuration_controller.cc View 3 chunks +25 lines, -9 lines 0 comments Download
M ash/display/display_configuration_controller_unittest.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M ash/rotator/screen_rotation_animator.h View 6 chunks +18 lines, -18 lines 0 comments Download
M ash/rotator/screen_rotation_animator.cc View 15 chunks +45 lines, -39 lines 0 comments Download
M ash/rotator/screen_rotation_animator_unittest.cc View 16 chunks +78 lines, -38 lines 0 comments Download
M ash/test/display_configuration_controller_test_api.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/test/display_configuration_controller_test_api.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M testing/buildbot/filters/ash_unittests_mus.filter View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Qiang(Joe) Xu
3 years, 6 months ago (2017-06-05 18:36:10 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6b279cbf120d6f980b40633aa6cb76d8e6af1125 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698