Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Unified Diff: ash/display/display_configuration_controller.h

Issue 2919393002: [merge to m60] cros: Do not cache |root_window| in ScreenRotationAnimator. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/display/display_configuration_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/display/display_configuration_controller.h
diff --git a/ash/display/display_configuration_controller.h b/ash/display/display_configuration_controller.h
index e67ee356c97f618170b13e6e41db20fdaf8fee1a..549e908e67f9e86e004dc26a76b38b905708bd7f 100644
--- a/ash/display/display_configuration_controller.h
+++ b/ash/display/display_configuration_controller.h
@@ -77,9 +77,10 @@ class ASH_EXPORT DisplayConfigurationController
void SetMirrorModeImpl(bool mirror);
void SetPrimaryDisplayIdImpl(int64_t display_id);
- // Returns the ScreenRotationAnimator associated with the |display_id|. If
- // there is no existing ScreenRotationAnimator for |display_id|, it will make
- // one and store the pair in the |rotation_animator_map_|.
+ // Returns the ScreenRotationAnimator associated with the |display_id|'s
+ // |root_window|. If there is no existing ScreenRotationAnimator for
+ // |root_window|, it will make one and store in the |root_window| property
+ // |kScreenRotationAnimatorKey|.
ScreenRotationAnimator* GetScreenRotationAnimatorForDisplay(
int64_t display_id);
@@ -88,14 +89,6 @@ class ASH_EXPORT DisplayConfigurationController
std::unique_ptr<DisplayAnimator> display_animator_;
std::unique_ptr<DisplayChangeLimiter> limiter_;
- // Tracks |display_id| to ScreenRotationAnimator mappings. The
- // |rotation_animator_map_| is populated on demand the first time a
- // ScreenRotationAnimator is needed for a given |display_id|.
- // On animation ended or aborted, the animator may be deleted if there is no
- // more pending rotation request.
- std::unordered_map<int64_t, std::unique_ptr<ScreenRotationAnimator>>
- rotation_animator_map_;
-
base::WeakPtrFactory<DisplayConfigurationController> weak_ptr_factory_;
DISALLOW_COPY_AND_ASSIGN(DisplayConfigurationController);
« no previous file with comments | « no previous file | ash/display/display_configuration_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698