Reland of bluetooth: Implement simulateGATTConnectionResponse()

Reland of bluetooth: Implement simulateGATTConnectionResponse()

Sets the next GATT Connection request response for peripheral with
|address| to |code|. |code| could be an HCI Error Code from
BT 4.2 Vol 2 Part D 1.3 List Of Error Codes or a number outside that range
returned by specific platforms e.g. Android returns 0x101 to signal a GATT
failure

LayoutTests that use Mojo don't run on Android yet: http://crbug.com/729898.
Removes device-same-object from SmokeTests to avoid it failing on bots.

First attemp at landing this CL: http://crrev.com/2874873003

TBR=blundell@chromium.org,dcheng@chromium.org,scheib@chromium.org

BUG=719814
Review-Url: https://codereview.chromium.org/2919343004
Cr-Commit-Position: refs/heads/master@{#477510}
Committed: https://chromium.googlesource.com/chromium/src/+/8799e7dac285e016327c6471863fb61a1405acab

[ortuno, 2017-06-06 03:59:07]

Created Reland of bluetooth: Implement simulateGATTConnectionResponse()

[ortuno, 2017-06-06 04:00:01]

Description was changed from

==========
Reland of bluetooth: Implement simulateGATTConnectionResponse() (patchset #1
id:1 of https://codereview.chromium.org/2921233002/ )

Reason for revert:
LayoutTests that use Mojo don't run on Android yet: http://crbug.com/729898
Removing test from SmokeTests fixes the issue.

Original issue's description:
> Revert of bluetooth: Implement simulateGATTConnectionResponse() (patchset #15
id:340001 of https://codereview.chromium.org/2874873003/ )
> 
> Reason for revert:
> Seems to cause device-same-object test to fail consistently on Android, e.g.:
> 
>
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.webkit%2FWebKit...
> 
> 
> Original issue's description:
> > bluetooth: Implement setNextGATTConnectionResponse()
> > 
> > Sets the next GATT Connection request response for peripheral with
> > |address| to |code|. |code| could be an HCI Error Code from
> > BT 4.2 Vol 2 Part D 1.3 List Of Error Codes or a number outside that range
> > returned by specific platforms e.g. Android returns 0x101 to signal a GATT
> > failure
> > 
> > BUG=719814
> > 
> > Review-Url: https://codereview.chromium.org/2874873003
> > Cr-Commit-Position: refs/heads/master@{#476940}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/a7f7ed7b9e28bc9da80a4d36297e...
> 
> TBR=dcheng@chromium.org,scheib@chromium.org,ortuno@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=719814
> 
> Review-Url: https://codereview.chromium.org/2921233002
> Cr-Commit-Position: refs/heads/master@{#476961}
> Committed:
https://chromium.googlesource.com/chromium/src/+/0255f6a703d6781b372fc905e634...

TBR=dcheng@chromium.org,scheib@chromium.org,blundell@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=719814
==========

to

==========
Reland of bluetooth: Implement simulateGATTConnectionResponse() (patchset #1
id:1 of https://codereview.chromium.org/2921233002/ )

Reason for revert:
LayoutTests that use Mojo don't run on Android yet: http://crbug.com/729898
Removing test from SmokeTests fixes the issue.

Original issue's description:
> Revert of bluetooth: Implement simulateGATTConnectionResponse() (patchset #15
id:340001 of https://codereview.chromium.org/2874873003/ )
> 
> Reason for revert:
> Seems to cause device-same-object test to fail consistently on Android, e.g.:
> 
>
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.webkit%2FWebKit...
> 
> 
> Original issue's description:
> > bluetooth: Implement setNextGATTConnectionResponse()
> > 
> > Sets the next GATT Connection request response for peripheral with
> > |address| to |code|. |code| could be an HCI Error Code from
> > BT 4.2 Vol 2 Part D 1.3 List Of Error Codes or a number outside that range
> > returned by specific platforms e.g. Android returns 0x101 to signal a GATT
> > failure
> > 
> > BUG=719814
> > 
> > Review-Url: https://codereview.chromium.org/2874873003
> > Cr-Commit-Position: refs/heads/master@{#476940}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/a7f7ed7b9e28bc9da80a4d36297e...
> 
> TBR=dcheng@chromium.org,scheib@chromium.org,ortuno@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=719814
> 
> Review-Url: https://codereview.chromium.org/2921233002
> Cr-Commit-Position: refs/heads/master@{#476961}
> Committed:
https://chromium.googlesource.com/chromium/src/+/0255f6a703d6781b372fc905e634...

BUG=719814
==========

[ortuno, 2017-06-06 04:03:45]

Description was changed from

==========
Reland of bluetooth: Implement simulateGATTConnectionResponse() (patchset #1
id:1 of https://codereview.chromium.org/2921233002/ )

Reason for revert:
LayoutTests that use Mojo don't run on Android yet: http://crbug.com/729898
Removing test from SmokeTests fixes the issue.

Original issue's description:
> Revert of bluetooth: Implement simulateGATTConnectionResponse() (patchset #15
id:340001 of https://codereview.chromium.org/2874873003/ )
> 
> Reason for revert:
> Seems to cause device-same-object test to fail consistently on Android, e.g.:
> 
>
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.webkit%2FWebKit...
> 
> 
> Original issue's description:
> > bluetooth: Implement setNextGATTConnectionResponse()
> > 
> > Sets the next GATT Connection request response for peripheral with
> > |address| to |code|. |code| could be an HCI Error Code from
> > BT 4.2 Vol 2 Part D 1.3 List Of Error Codes or a number outside that range
> > returned by specific platforms e.g. Android returns 0x101 to signal a GATT
> > failure
> > 
> > BUG=719814
> > 
> > Review-Url: https://codereview.chromium.org/2874873003
> > Cr-Commit-Position: refs/heads/master@{#476940}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/a7f7ed7b9e28bc9da80a4d36297e...
> 
> TBR=dcheng@chromium.org,scheib@chromium.org,ortuno@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=719814
> 
> Review-Url: https://codereview.chromium.org/2921233002
> Cr-Commit-Position: refs/heads/master@{#476961}
> Committed:
https://chromium.googlesource.com/chromium/src/+/0255f6a703d6781b372fc905e634...

BUG=719814
==========

to

==========
Reland of bluetooth: Implement simulateGATTConnectionResponse() (patchset #1
id:1 of https://codereview.chromium.org/2921233002/ )

Reason for revert:
LayoutTests that use Mojo don't run on Android yet: http://crbug.com/729898
Removing test from SmokeTests fixes the issue.

Original issue's description:
> Revert of bluetooth: Implement simulateGATTConnectionResponse() (patchset #15
id:340001 of https://codereview.chromium.org/2874873003/ )
> 
> Reason for revert:
> Seems to cause device-same-object test to fail consistently on Android, e.g.:
> 
>
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.webkit%2FWebKit...
> 
> 
> Original issue's description:
> > bluetooth: Implement setNextGATTConnectionResponse()
> > 
> > Sets the next GATT Connection request response for peripheral with
> > |address| to |code|. |code| could be an HCI Error Code from
> > BT 4.2 Vol 2 Part D 1.3 List Of Error Codes or a number outside that range
> > returned by specific platforms e.g. Android returns 0x101 to signal a GATT
> > failure
> > 
> > BUG=719814
> > 
> > Review-Url: https://codereview.chromium.org/2874873003
> > Cr-Commit-Position: refs/heads/master@{#476940}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/a7f7ed7b9e28bc9da80a4d36297e...
> 
> TBR=dcheng@chromium.org,scheib@chromium.org,ortuno@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=719814
> 
> Review-Url: https://codereview.chromium.org/2921233002
> Cr-Commit-Position: refs/heads/master@{#476961}
> Committed:
https://chromium.googlesource.com/chromium/src/+/0255f6a703d6781b372fc905e634...

TBR=blundell@chromium.org,dcheng@chromium.org,scheib@chromium.org

BUG=719814
==========

[ortuno, 2017-06-06 04:06:01]

Description was changed from

==========
Reland of bluetooth: Implement simulateGATTConnectionResponse() (patchset #1
id:1 of https://codereview.chromium.org/2921233002/ )

Reason for revert:
LayoutTests that use Mojo don't run on Android yet: http://crbug.com/729898
Removing test from SmokeTests fixes the issue.

Original issue's description:
> Revert of bluetooth: Implement simulateGATTConnectionResponse() (patchset #15
id:340001 of https://codereview.chromium.org/2874873003/ )
> 
> Reason for revert:
> Seems to cause device-same-object test to fail consistently on Android, e.g.:
> 
>
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.webkit%2FWebKit...
> 
> 
> Original issue's description:
> > bluetooth: Implement setNextGATTConnectionResponse()
> > 
> > Sets the next GATT Connection request response for peripheral with
> > |address| to |code|. |code| could be an HCI Error Code from
> > BT 4.2 Vol 2 Part D 1.3 List Of Error Codes or a number outside that range
> > returned by specific platforms e.g. Android returns 0x101 to signal a GATT
> > failure
> > 
> > BUG=719814
> > 
> > Review-Url: https://codereview.chromium.org/2874873003
> > Cr-Commit-Position: refs/heads/master@{#476940}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/a7f7ed7b9e28bc9da80a4d36297e...
> 
> TBR=dcheng@chromium.org,scheib@chromium.org,ortuno@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=719814
> 
> Review-Url: https://codereview.chromium.org/2921233002
> Cr-Commit-Position: refs/heads/master@{#476961}
> Committed:
https://chromium.googlesource.com/chromium/src/+/0255f6a703d6781b372fc905e634...

TBR=blundell@chromium.org,dcheng@chromium.org,scheib@chromium.org

BUG=719814
==========

to

==========
Reland of bluetooth: Implement simulateGATTConnectionResponse() (patchset #1
id:1 of https://codereview.chromium.org/2921233002/ )

Reason for revert:
LayoutTests that use Mojo don't run on Android yet: http://crbug.com/729898
Removing test from SmokeTests stops it from failing on bots.

Original issue's description:
> Revert of bluetooth: Implement simulateGATTConnectionResponse() (patchset #15
id:340001 of https://codereview.chromium.org/2874873003/ )
> 
> Reason for revert:
> Seems to cause device-same-object test to fail consistently on Android, e.g.:
> 
>
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.webkit%2FWebKit...
> 
> 
> Original issue's description:
> > bluetooth: Implement setNextGATTConnectionResponse()
> > 
> > Sets the next GATT Connection request response for peripheral with
> > |address| to |code|. |code| could be an HCI Error Code from
> > BT 4.2 Vol 2 Part D 1.3 List Of Error Codes or a number outside that range
> > returned by specific platforms e.g. Android returns 0x101 to signal a GATT
> > failure
> > 
> > BUG=719814
> > 
> > Review-Url: https://codereview.chromium.org/2874873003
> > Cr-Commit-Position: refs/heads/master@{#476940}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/a7f7ed7b9e28bc9da80a4d36297e...
> 
> TBR=dcheng@chromium.org,scheib@chromium.org,ortuno@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=719814
> 
> Review-Url: https://codereview.chromium.org/2921233002
> Cr-Commit-Position: refs/heads/master@{#476961}
> Committed:
https://chromium.googlesource.com/chromium/src/+/0255f6a703d6781b372fc905e634...

TBR=blundell@chromium.org,dcheng@chromium.org,scheib@chromium.org

BUG=719814
==========

[ortuno, 2017-06-06 04:06:35]

ortuno@chromium.org changed reviewers:
+ peter@chromium.org

[ortuno, 2017-06-06 04:06:36]

peter: PTAL at SmokeTests.

[ortuno, 2017-06-06 04:06:42]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-06 04:07:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 05:51:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 05:51:50]

Dry run: This issue passed the CQ dry run.

[dcheng, 2017-06-06 07:01:34]

Rietveld has a funny opinion of what the diff between PS1 and PS2 is but IPC rs
lgtm

[blundell, 2017-06-06 07:26:41]

How difficult would it be to fix the Android issue and then reland the original
CL? Otherwise the next person to come along will hit the same issue, which seems
unfortunate.

Assuming that you land this, could you clean up the CL description to just be
the original CL description plus an addendum of the change that you made for the
reland?

[Peter Beverloo, 2017-06-06 10:59:24]

lgtm

[scheib, 2017-06-06 22:49:34]

lgtm

[ortuno, 2017-06-07 01:34:49]

Description was changed from

==========
Reland of bluetooth: Implement simulateGATTConnectionResponse() (patchset #1
id:1 of https://codereview.chromium.org/2921233002/ )

Reason for revert:
LayoutTests that use Mojo don't run on Android yet: http://crbug.com/729898
Removing test from SmokeTests stops it from failing on bots.

Original issue's description:
> Revert of bluetooth: Implement simulateGATTConnectionResponse() (patchset #15
id:340001 of https://codereview.chromium.org/2874873003/ )
> 
> Reason for revert:
> Seems to cause device-same-object test to fail consistently on Android, e.g.:
> 
>
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.webkit%2FWebKit...
> 
> 
> Original issue's description:
> > bluetooth: Implement setNextGATTConnectionResponse()
> > 
> > Sets the next GATT Connection request response for peripheral with
> > |address| to |code|. |code| could be an HCI Error Code from
> > BT 4.2 Vol 2 Part D 1.3 List Of Error Codes or a number outside that range
> > returned by specific platforms e.g. Android returns 0x101 to signal a GATT
> > failure
> > 
> > BUG=719814
> > 
> > Review-Url: https://codereview.chromium.org/2874873003
> > Cr-Commit-Position: refs/heads/master@{#476940}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/a7f7ed7b9e28bc9da80a4d36297e...
> 
> TBR=dcheng@chromium.org,scheib@chromium.org,ortuno@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=719814
> 
> Review-Url: https://codereview.chromium.org/2921233002
> Cr-Commit-Position: refs/heads/master@{#476961}
> Committed:
https://chromium.googlesource.com/chromium/src/+/0255f6a703d6781b372fc905e634...

TBR=blundell@chromium.org,dcheng@chromium.org,scheib@chromium.org

BUG=719814
==========

to

==========
Reland of bluetooth: Implement simulateGATTConnectionResponse()

Sets the next GATT Connection request response for peripheral with
|address| to |code|. |code| could be an HCI Error Code from
BT 4.2 Vol 2 Part D 1.3 List Of Error Codes or a number outside that range
returned by specific platforms e.g. Android returns 0x101 to signal a GATT
failure

LayoutTests that use Mojo don't run on Android yet: http://crbug.com/729898.
Removes test from SmokeTests stop it from failing on bots.


TBR=blundell@chromium.org,dcheng@chromium.org,scheib@chromium.org

BUG=719814
==========

[ortuno, 2017-06-07 01:41:54]

On 2017/06/06 at 07:26:41, blundell wrote:
> How difficult would it be to fix the Android issue and then reland the
original CL? Otherwise the next person to come along will hit the same issue,
which seems unfortunate.

I've been looking at it in my spare cycles. It seems is just a matter of
changing the run_layout_tests script to copy over the generated files and make
sure it works on bots. This is blocking other work so I'll land this an continue
working on it in parallel.

> 
> Assuming that you land this, could you clean up the CL description to just be
the original CL description plus an addendum of the change that you made for the
reland?

Done.

[ortuno, 2017-06-07 01:42:47]

Description was changed from

==========
Reland of bluetooth: Implement simulateGATTConnectionResponse()

Sets the next GATT Connection request response for peripheral with
|address| to |code|. |code| could be an HCI Error Code from
BT 4.2 Vol 2 Part D 1.3 List Of Error Codes or a number outside that range
returned by specific platforms e.g. Android returns 0x101 to signal a GATT
failure

LayoutTests that use Mojo don't run on Android yet: http://crbug.com/729898.
Removes test from SmokeTests stop it from failing on bots.


TBR=blundell@chromium.org,dcheng@chromium.org,scheib@chromium.org

BUG=719814
==========

to

==========
Reland of bluetooth: Implement simulateGATTConnectionResponse()

Sets the next GATT Connection request response for peripheral with
|address| to |code|. |code| could be an HCI Error Code from
BT 4.2 Vol 2 Part D 1.3 List Of Error Codes or a number outside that range
returned by specific platforms e.g. Android returns 0x101 to signal a GATT
failure

LayoutTests that use Mojo don't run on Android yet: http://crbug.com/729898.
Removes device-same-object from SmokeTests to avoid it failing on bots.


TBR=blundell@chromium.org,dcheng@chromium.org,scheib@chromium.org

BUG=719814
==========

[ortuno, 2017-06-07 01:43:03]

The CQ bit was checked by ortuno@chromium.org

[commit-bot: I haz the power, 2017-06-07 01:43:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 01:48:49]

CQ is committing da patch.

Bot data: {"patchset_id": 290001, "attempt_start_ts": 1496799783209760,
"parent_rev": "293673c15ba5fd3f01234e7c594444e84c483660", "commit_rev":
"8799e7dac285e016327c6471863fb61a1405acab"}

[commit-bot: I haz the power, 2017-06-07 01:49:00]

Description was changed from

==========
Reland of bluetooth: Implement simulateGATTConnectionResponse()

Sets the next GATT Connection request response for peripheral with
|address| to |code|. |code| could be an HCI Error Code from
BT 4.2 Vol 2 Part D 1.3 List Of Error Codes or a number outside that range
returned by specific platforms e.g. Android returns 0x101 to signal a GATT
failure

LayoutTests that use Mojo don't run on Android yet: http://crbug.com/729898.
Removes device-same-object from SmokeTests to avoid it failing on bots.


TBR=blundell@chromium.org,dcheng@chromium.org,scheib@chromium.org

BUG=719814
==========

to

==========
Reland of bluetooth: Implement simulateGATTConnectionResponse()

Sets the next GATT Connection request response for peripheral with
|address| to |code|. |code| could be an HCI Error Code from
BT 4.2 Vol 2 Part D 1.3 List Of Error Codes or a number outside that range
returned by specific platforms e.g. Android returns 0x101 to signal a GATT
failure

LayoutTests that use Mojo don't run on Android yet: http://crbug.com/729898.
Removes device-same-object from SmokeTests to avoid it failing on bots.


TBR=blundell@chromium.org,dcheng@chromium.org,scheib@chromium.org

BUG=719814

Review-Url: https://codereview.chromium.org/2919343004
Cr-Commit-Position: refs/heads/master@{#477510}
Committed:
https://chromium.googlesource.com/chromium/src/+/8799e7dac285e016327c6471863f...
==========

[commit-bot: I haz the power, 2017-06-07 01:49:03]

Committed patchset #2 (id:290001) as
https://chromium.googlesource.com/chromium/src/+/8799e7dac285e016327c6471863f...

[ortuno, 2017-06-07 01:50:04]

Description was changed from

==========
Reland of bluetooth: Implement simulateGATTConnectionResponse()

Sets the next GATT Connection request response for peripheral with
|address| to |code|. |code| could be an HCI Error Code from
BT 4.2 Vol 2 Part D 1.3 List Of Error Codes or a number outside that range
returned by specific platforms e.g. Android returns 0x101 to signal a GATT
failure

LayoutTests that use Mojo don't run on Android yet: http://crbug.com/729898.
Removes device-same-object from SmokeTests to avoid it failing on bots.


TBR=blundell@chromium.org,dcheng@chromium.org,scheib@chromium.org

BUG=719814

Review-Url: https://codereview.chromium.org/2919343004
Cr-Commit-Position: refs/heads/master@{#477510}
Committed:
https://chromium.googlesource.com/chromium/src/+/8799e7dac285e016327c6471863f...
==========

to

==========
Reland of bluetooth: Implement simulateGATTConnectionResponse()

Sets the next GATT Connection request response for peripheral with
|address| to |code|. |code| could be an HCI Error Code from
BT 4.2 Vol 2 Part D 1.3 List Of Error Codes or a number outside that range
returned by specific platforms e.g. Android returns 0x101 to signal a GATT
failure

LayoutTests that use Mojo don't run on Android yet: http://crbug.com/729898.
Removes device-same-object from SmokeTests to avoid it failing on bots.

First attemp at landing this CL: http://crrev.com/2874873003

TBR=blundell@chromium.org,dcheng@chromium.org,scheib@chromium.org

BUG=719814

Review-Url: https://codereview.chromium.org/2919343004
Cr-Commit-Position: refs/heads/master@{#477510}
Committed:
https://chromium.googlesource.com/chromium/src/+/8799e7dac285e016327c6471863f...
==========