Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2921233002: Revert of bluetooth: Implement simulateGATTConnectionResponse() (Closed)

Created:
3 years, 6 months ago by blundell
Modified:
3 years, 6 months ago
Reviewers:
scheib, ortuno, dcheng
CC:
Aaron Boodman, abarth-chromium, blink-reviews, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, ortuno+watch_chromium.org, qsr+mojo_chromium.org, scheib+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of bluetooth: Implement simulateGATTConnectionResponse() (patchset #15 id:340001 of https://codereview.chromium.org/2874873003/ ) Reason for revert: Seems to cause device-same-object test to fail consistently on Android, e.g.: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.webkit%2FWebKit_Android__Nexus4_%2F65576%2F%2B%2Frecipes%2Fsteps%2Fwebkit_tests%2F0%2Fstdout Original issue's description: > bluetooth: Implement setNextGATTConnectionResponse() > > Sets the next GATT Connection request response for peripheral with > |address| to |code|. |code| could be an HCI Error Code from > BT 4.2 Vol 2 Part D 1.3 List Of Error Codes or a number outside that range > returned by specific platforms e.g. Android returns 0x101 to signal a GATT > failure > > BUG=719814 > > Review-Url: https://codereview.chromium.org/2874873003 > Cr-Commit-Position: refs/heads/master@{#476940} > Committed: https://chromium.googlesource.com/chromium/src/+/a7f7ed7b9e28bc9da80a4d36297efa9e3e31871c TBR=dcheng@chromium.org,scheib@chromium.org,ortuno@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=719814 Review-Url: https://codereview.chromium.org/2921233002 Cr-Commit-Position: refs/heads/master@{#476961} Committed: https://chromium.googlesource.com/chromium/src/+/0255f6a703d6781b372fc905e6344722dce0abb9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -239 lines) Patch
M content/browser/bluetooth/bluetooth_device_chooser_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M device/bluetooth/public/interfaces/test/fake_bluetooth.mojom View 2 chunks +0 lines, -17 lines 0 comments Download
M device/bluetooth/test/fake_central.h View 1 chunk +0 lines, -4 lines 0 comments Download
M device/bluetooth/test/fake_central.cc View 1 chunk +1 line, -17 lines 0 comments Download
M device/bluetooth/test/fake_peripheral.h View 3 chunks +3 lines, -26 lines 0 comments Download
M device/bluetooth/test/fake_peripheral.cc View 5 chunks +6 lines, -51 lines 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/server/invalid-service-name.js View 1 chunk +6 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/script-tests/server/no-permission-for-any-service.js View 2 chunks +7 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/server/connect/connection-succeeds.html View 1 chunk +5 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/server/connect/garbage-collection-ran-during-success.html View 1 chunk +6 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/server/connect/get-same-gatt-server.html View 1 chunk +8 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/server/device-same-object.html View 1 chunk +6 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryService/gen-invalid-service-name.html View 1 chunk +6 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryService/gen-no-permission-for-any-service.html View 1 chunk +7 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/gen-invalid-service-name.html View 1 chunk +6 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/gen-no-permission-for-any-service.html View 1 chunk +7 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/server/getPrimaryServices/gen-no-permission-for-any-service-with-uuid.html View 1 chunk +7 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js View 4 chunks +0 lines, -42 lines 0 comments Download
M third_party/WebKit/LayoutTests/resources/bluetooth/web-bluetooth-test.js View 2 chunks +3 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
blundell
Created Revert of bluetooth: Implement simulateGATTConnectionResponse()
3 years, 6 months ago (2017-06-05 09:16:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2921233002/1
3 years, 6 months ago (2017-06-05 09:16:51 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/0255f6a703d6781b372fc905e6344722dce0abb9
3 years, 6 months ago (2017-06-05 09:17:33 UTC) #6
ortuno
3 years, 6 months ago (2017-06-06 03:59:06 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2919343004/ by ortuno@chromium.org.

The reason for reverting is: LayoutTests that use Mojo don't run on Android yet:
http://crbug.com/729898 Removing test from SmokeTests fixes the issue..

Powered by Google App Engine
This is Rietveld 408576698