Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1777)

Unified Diff: third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl

Issue 2919343002: Remove template parameter on ComputedStyleBase. (Closed)
Patch Set: Address comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl
diff --git a/third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl b/third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl
index 74fcdeb6584a9243cfc6cd7282d286417b11e426..531391be0c65d398e78c098abaaf8aedcdc9afe8 100644
--- a/third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl
+++ b/third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl
@@ -123,16 +123,16 @@ unsigned {{field.name}} : {{field.size}}; // {{field.type_name}}
{% macro fieldwise_diff(group_to_diff) %}
{% for group in group_to_diff.subgroups %}
-if ({{group.group_name}}.Get() != other.{{group.group_name}}.Get()) {
+if (a.{{group.group_name}}.Get() != b.{{group.group_name}}.Get()) {
{{fieldwise_diff(group)|indent(2, true)}}
}
{% endfor %}
{% for expression in group_to_diff.expressions %}
-if (self.{{expression}} != other.{{expression}})
+if (a.{{expression}} != b.{{expression}})
return true;
{% endfor %}
{% for predicate in group_to_diff.predicates %}
-if (!self.{{predicate}})
+if (!{{predicate}})
return true;
{% endfor %}
{% endmacro %}

Powered by Google App Engine
This is Rietveld 408576698