Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: third_party/WebKit/Source/build/scripts/templates/fields/group.tmpl

Issue 2919343002: Remove template parameter on ComputedStyleBase. (Closed)
Patch Set: Address comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/build/scripts/templates/fields/group.tmpl
diff --git a/third_party/WebKit/Source/build/scripts/templates/fields/group.tmpl b/third_party/WebKit/Source/build/scripts/templates/fields/group.tmpl
index 92d246cd43dc3b7debef847eb4ea102bc0a2c489..3e644f9ed3c90ecdf21830351aaa59277d292d47 100644
--- a/third_party/WebKit/Source/build/scripts/templates/fields/group.tmpl
+++ b/third_party/WebKit/Source/build/scripts/templates/fields/group.tmpl
@@ -1,6 +1,6 @@
{% from 'fields/field.tmpl' import encode, declare_storage, compare %}
{% from 'macros.tmpl' import print_if %}
-{% macro define_field_group_class(group): -%}
+{% macro declare_field_group_class(group): -%}
class {{group.type_name}} : public RefCounted<{{group.type_name}}> {
public:
static PassRefPtr<{{group.type_name}}> Create() {
@@ -24,20 +24,25 @@ class {{group.type_name}} : public RefCounted<{{group.type_name}}> {
{% endfor %}
private:
- {{group.type_name}}() :
+ {{group.type_name}}();
+ {{group.type_name}}(const {{group.type_name}}&);
+};
+{%- endmacro %}
+
+{% macro define_field_group_class(group): -%}
+ComputedStyleBase::{{group.type_name}}::{{group.type_name}}() :
{% for field in group.fields %}
{{field.name}}({{encode(field, field.default_value)}}){{print_if(not loop.last, ',')}}
{% endfor %}
{}
- {{group.type_name}}(const {{group.type_name}}& other) :
+ComputedStyleBase::{{group.type_name}}::{{group.type_name}}(const {{group.type_name}}& other) :
{% for field in group.fields %}
- {% if field.wrapper_pointer_name %}
+ {% if field.wrapper_pointer_name %}
{{field.name}}(MemberCopy(other.{{field.name}})){{print_if(not loop.last, ',')}}
- {% else %}
+ {% else %}
{{field.name}}(other.{{field.name}}){{print_if(not loop.last, ',')}}
- {% endif %}
+ {% endif %}
{% endfor %}
{}
-};
{%- endmacro %}
« no previous file with comments | « third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl ('k') | third_party/WebKit/Source/core/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698