Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Side by Side Diff: third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl

Issue 2919343002: Remove template parameter on ComputedStyleBase. (Closed)
Patch Set: Address comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 {% macro encode(field, value) %} 1 {% macro encode(field, value) %}
2 {% if field.is_bit_field -%} 2 {% if field.is_bit_field -%}
3 static_cast<unsigned>({{value}}) 3 static_cast<unsigned>({{value}})
4 {%- else -%} 4 {%- else -%}
5 {{value}} 5 {{value}}
6 {%- endif %} 6 {%- endif %}
7 {% endmacro %} 7 {% endmacro %}
8 8
9 {% macro decode(field, value) %} 9 {% macro decode(field, value) %}
10 {% if field.is_bit_field -%} 10 {% if field.is_bit_field -%}
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
116 {{fieldwise_pointer_compare_inherited(fields_to_compare)}} 116 {{fieldwise_pointer_compare_inherited(fields_to_compare)}}
117 {% endif %} 117 {% endif %}
118 {% endfor %} 118 {% endfor %}
119 {% for field in group.fields if field.is_inherited -%} 119 {% for field in group.fields if field.is_inherited -%}
120 {{getter_expression(field)}} == o.{{getter_expression(field)}} && 120 {{getter_expression(field)}} == o.{{getter_expression(field)}} &&
121 {% endfor %} 121 {% endfor %}
122 {% endmacro %} 122 {% endmacro %}
123 123
124 {% macro fieldwise_diff(group_to_diff) %} 124 {% macro fieldwise_diff(group_to_diff) %}
125 {% for group in group_to_diff.subgroups %} 125 {% for group in group_to_diff.subgroups %}
126 if ({{group.group_name}}.Get() != other.{{group.group_name}}.Get()) { 126 if (a.{{group.group_name}}.Get() != b.{{group.group_name}}.Get()) {
127 {{fieldwise_diff(group)|indent(2, true)}} 127 {{fieldwise_diff(group)|indent(2, true)}}
128 } 128 }
129 {% endfor %} 129 {% endfor %}
130 {% for expression in group_to_diff.expressions %} 130 {% for expression in group_to_diff.expressions %}
131 if (self.{{expression}} != other.{{expression}}) 131 if (a.{{expression}} != b.{{expression}})
132 return true; 132 return true;
133 {% endfor %} 133 {% endfor %}
134 {% for predicate in group_to_diff.predicates %} 134 {% for predicate in group_to_diff.predicates %}
135 if (!self.{{predicate}}) 135 if (!{{predicate}})
136 return true; 136 return true;
137 {% endfor %} 137 {% endfor %}
138 {% endmacro %} 138 {% endmacro %}
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698