Reapply "Use backend targets to run Kernel transformations in Fasta"

Reapply "Use backend targets to run Kernel transformations in Fasta"

This reverts commit 0b424ca5d2b89961de478475ff5b7182e25efe47

R=ahe@google.com

Committed: https://github.com/dart-lang/sdk/commit/1e2f06f8da50614ec974a8ca35e7dd8aa0dcd930

[Dmitry Stefantsov, 2017-06-02 11:06:03]

Description was changed from

==========
Reapply "Use backend targets to run Kernel transformations in Fasta"
==========

to

==========
Reapply "Use backend targets to run Kernel transformations in Fasta"

This reverts commit 0b424ca5d2b89961de478475ff5b7182e25efe47
==========

[Dmitry Stefantsov, 2017-06-02 12:56:05]

Patchset #3 (id:40001) has been deleted

[Dmitry Stefantsov, 2017-06-02 13:40:24]

dmitryas@google.com changed reviewers:
+ ahe@google.com, kmillikin@google.com

[Dmitry Stefantsov, 2017-06-02 13:40:25]

PTAL

Review of Patch Set 1 is already done here:
https://codereview.chromium.org/2918623004/

[ahe, 2017-06-02 14:07:46]

lgtm

https://codereview.chromium.org/2919003003/diff/80001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/dill/dill_target.dart (right):

https://codereview.chromium.org/2919003003/diff/80001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/dill/dill_target.dart:29:
getTarget(backendTargetName, flags ?? new TargetFlags())) {
Since we need to pass in TargetFlags now, perhaps it would be a good time to
switch from

String backendTargetName

to

Target backendTarget

[ahe, 2017-06-02 14:08:07]

+Konstantin

[Dmitry Stefantsov, 2017-06-02 14:10:35]

Description was changed from

==========
Reapply "Use backend targets to run Kernel transformations in Fasta"

This reverts commit 0b424ca5d2b89961de478475ff5b7182e25efe47
==========

to

==========
Reapply "Use backend targets to run Kernel transformations in Fasta"

This reverts commit 0b424ca5d2b89961de478475ff5b7182e25efe47

R=ahe@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1e2f06f8da50614ec974a8ca35e7dd8aa0dcd930
==========

[Dmitry Stefantsov, 2017-06-02 14:10:37]

Committed patchset #4 (id:80001) manually as
1e2f06f8da50614ec974a8ca35e7dd8aa0dcd930 (presubmit successful).

[Dmitry Stefantsov, 2017-06-02 14:28:54]

https://codereview.chromium.org/2919003003/diff/80001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/dill/dill_target.dart (right):

https://codereview.chromium.org/2919003003/diff/80001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/dill/dill_target.dart:29:
getTarget(backendTargetName, flags ?? new TargetFlags())) {
On 2017/06/02 14:07:46, ahe wrote:
> Since we need to pass in TargetFlags now, perhaps it would be a good time to
> switch from
> 
> String backendTargetName
> 
> to
> 
> Target backendTarget
> 

Sorry for missing this comment before landing. I agree. I'll create a new CL
with this change.

[ahe, 2017-06-02 14:30:19]

https://codereview.chromium.org/2919003003/diff/80001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/dill/dill_target.dart (right):

https://codereview.chromium.org/2919003003/diff/80001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/dill/dill_target.dart:29:
getTarget(backendTargetName, flags ?? new TargetFlags())) {
On 2017/06/02 14:28:53, Dmitry Stefantsov wrote:
> On 2017/06/02 14:07:46, ahe wrote:
> > Since we need to pass in TargetFlags now, perhaps it would be a good time to
> > switch from
> > 
> > String backendTargetName
> > 
> > to
> > 
> > Target backendTarget
> > 
> 
> Sorry for missing this comment before landing. I agree. I'll create a new CL
> with this change.

Great!

[scheglov, 2017-06-02 15:26:22]

scheglov@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2017-06-02 15:26:22]

LGTM