Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: pkg/front_end/lib/src/fasta/dill/dill_target.dart

Issue 2919003003: Reapply "Use backend targets to run Kernel transformations in Fasta" (Closed)
Patch Set: Follow dartanalyzer suggestions Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/front_end/lib/src/fasta/compiler_command_line.dart ('k') | pkg/front_end/lib/src/fasta/fasta.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/lib/src/fasta/dill/dill_target.dart
diff --git a/pkg/front_end/lib/src/fasta/dill/dill_target.dart b/pkg/front_end/lib/src/fasta/dill/dill_target.dart
index c628e52b2f264bc12876a15fa5b77cfa5bb2fb71..8906c3c981ec6cd95a4ced2ad089b50a812557c6 100644
--- a/pkg/front_end/lib/src/fasta/dill/dill_target.dart
+++ b/pkg/front_end/lib/src/fasta/dill/dill_target.dart
@@ -8,7 +8,7 @@ import 'dart:async' show Future;
import 'package:kernel/ast.dart' show Class;
-import 'package:kernel/target/targets.dart' show getTarget;
+import 'package:kernel/target/targets.dart' show getTarget, TargetFlags;
import '../errors.dart' show internalError;
import '../kernel/kernel_builder.dart' show ClassBuilder;
@@ -23,8 +23,10 @@ class DillTarget extends TargetImplementation {
DillLoader loader;
DillTarget(
- Ticker ticker, TranslateUri uriTranslator, String backendTargetName)
- : super(ticker, uriTranslator, getTarget(backendTargetName, null)) {
+ Ticker ticker, TranslateUri uriTranslator, String backendTargetName,
+ {TargetFlags flags})
+ : super(ticker, uriTranslator,
+ getTarget(backendTargetName, flags ?? new TargetFlags())) {
ahe 2017/06/02 14:07:46 Since we need to pass in TargetFlags now, perhaps
Dmitry Stefantsov 2017/06/02 14:28:53 Sorry for missing this comment before landing. I a
ahe 2017/06/02 14:30:19 Great!
loader = new DillLoader(this);
}
« no previous file with comments | « pkg/front_end/lib/src/fasta/compiler_command_line.dart ('k') | pkg/front_end/lib/src/fasta/fasta.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698