Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(865)

Unified Diff: pkg/kernel/test/baseline_tester.dart

Issue 2919003003: Reapply "Use backend targets to run Kernel transformations in Fasta" (Closed)
Patch Set: Follow dartanalyzer suggestions Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/kernel/test/baseline_tester.dart
diff --git a/pkg/kernel/test/baseline_tester.dart b/pkg/kernel/test/baseline_tester.dart
index a7b3715d0872d3a884bbb1e07ab8688a2fcc1548..fb7fb2b85ed81728a84ce68175a3506c61dce4b0 100644
--- a/pkg/kernel/test/baseline_tester.dart
+++ b/pkg/kernel/test/baseline_tester.dart
@@ -27,10 +27,12 @@ abstract class TestTarget extends Target {
Annotator get annotator => null;
// Return a list of strings so that we can accumulate errors.
- List<String> performModularTransformations(
- CoreTypes coreTypes, ClassHierarchy hierarchy, Program program);
+ List<String> performModularTransformationsOnProgram(
+ CoreTypes coreTypes, ClassHierarchy hierarchy, Program program,
+ {void logger(String msg)});
List<String> performGlobalTransformations(
- CoreTypes coreTypes, Program program);
+ CoreTypes coreTypes, Program program,
+ {void logger(String msg)});
}
void runBaselineTests(String folderName, TestTarget target) {
@@ -61,7 +63,7 @@ void runBaselineTests(String folderName, TestTarget target) {
loader.loadProgram(dartPath, target: target);
verifyProgram(program);
var errors = <String>[];
- errors.addAll(target.performModularTransformations(
+ errors.addAll(target.performModularTransformationsOnProgram(
coreTypes, hierarchy, program));
verifyProgram(program);
errors.addAll(target.performGlobalTransformations(coreTypes, program));

Powered by Google App Engine
This is Rietveld 408576698