Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2918993003: DevTools: allow shallow array values in console.table (Closed)

Created:
3 years, 6 months ago by luoe
Modified:
3 years, 6 months ago
Reviewers:
dgozman
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: allow shallow array values in console.table Today's console.table() implementation only looks at nested array values `console.table([[1, 2, 3]])`. It ignores shallow array values, so commands such as `console.table([1, 2, 3])` will not show anything. To more closely align with the living standard supported in other browsers, this CL finally brings supports to shallow values with a new 'Value' column. Screenshot: http://imgur.com/a/c3afb BUG=663878 Review-Url: https://codereview.chromium.org/2918993003 Cr-Commit-Position: refs/heads/master@{#476852} Committed: https://chromium.googlesource.com/chromium/src/+/f312e41ce160dcb406f68f41b7fa96232efcf48d

Patch Set 1 #

Total comments: 2

Patch Set 2 : ac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/inspector/console/console-format-table.html View 1 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-format-table-expected.txt View 1 4 chunks +32 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js View 1 2 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
luoe
This behavior is much closer to other browsers. Cross-browser notes: - Firefox's column is named ...
3 years, 6 months ago (2017-06-02 18:00:20 UTC) #3
dgozman
https://codereview.chromium.org/2918993003/diff/1/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js File third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js (right): https://codereview.chromium.org/2918993003/diff/1/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js#newcode142 third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:142: rowSubProperties = [{name: Common.UIString('Value'), type: rowProperty.type, value: rowProperty.value}]; This ...
3 years, 6 months ago (2017-06-02 22:02:32 UTC) #4
luoe
ptal https://codereview.chromium.org/2918993003/diff/1/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js File third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js (right): https://codereview.chromium.org/2918993003/diff/1/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js#newcode142 third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:142: rowSubProperties = [{name: Common.UIString('Value'), type: rowProperty.type, value: rowProperty.value}]; ...
3 years, 6 months ago (2017-06-02 22:18:17 UTC) #6
dgozman
lgtm
3 years, 6 months ago (2017-06-02 22:38:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2918993003/20001
3 years, 6 months ago (2017-06-02 22:40:07 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-03 01:55:12 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f312e41ce160dcb406f68f41b7fa...

Powered by Google App Engine
This is Rietveld 408576698