DevTools: allow shallow array values in console.table

DevTools: allow shallow array values in console.table

Today's console.table() implementation only looks at nested array values
`console.table([[1, 2, 3]])`. It ignores shallow array values, so commands such
as `console.table([1, 2, 3])` will not show anything.

To more closely align with the living standard supported in other browsers, this
CL finally brings supports to shallow values with a new 'Value' column.

Screenshot: http://imgur.com/a/c3afb

BUG=663878
Review-Url: https://codereview.chromium.org/2918993003
Cr-Commit-Position: refs/heads/master@{#476852}
Committed: https://chromium.googlesource.com/chromium/src/+/f312e41ce160dcb406f68f41b7fa96232efcf48d

[luoe, 2017-06-02 17:55:39]

Description was changed from

==========
DevTools: allow shallow array values in console.table

BUG=663878
==========

to

==========
DevTools: allow shallow array values in console.table

Today's console.table() implementation only looks at nested array values
`console.table([[1, 2, 3]])`. It ignores shallow array values, so commands such
as `console.table([1, 2, 3])` will not show anything.

To more closely align with the living standard supported in other browsers, this
CL finally brings supports to shallow values with a new 'Value' column.

BUG=663878
==========

[luoe, 2017-06-02 18:00:19]

luoe@chromium.org changed reviewers:
+ dgozman@chromium.org

[luoe, 2017-06-02 18:00:20]

This behavior is much closer to other browsers.

Cross-browser notes:
- Firefox's column is named 'Values' while Safari's is named 'Value'.
- Firefox shows both shallow and deep properties, while Safari will drop the
shallow properties when both types are present.

This CL uses the 'Value' column name and doesn't drop shallow properties when
deep properties are present as well.

Please take a look!

[dgozman, 2017-06-02 22:02:32]

https://codereview.chromium.org/2918993003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
(right):

https://codereview.chromium.org/2918993003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:142:
rowSubProperties = [{name: Common.UIString('Value'), type: rowProperty.type,
value: rowProperty.value}];
This new column could match one of the properties. Let's follow other browsers
in this regard.

[luoe, 2017-06-02 22:15:10]

Description was changed from

==========
DevTools: allow shallow array values in console.table

Today's console.table() implementation only looks at nested array values
`console.table([[1, 2, 3]])`. It ignores shallow array values, so commands such
as `console.table([1, 2, 3])` will not show anything.

To more closely align with the living standard supported in other browsers, this
CL finally brings supports to shallow values with a new 'Value' column.

BUG=663878
==========

to

==========
DevTools: allow shallow array values in console.table

Today's console.table() implementation only looks at nested array values
`console.table([[1, 2, 3]])`. It ignores shallow array values, so commands such
as `console.table([1, 2, 3])` will not show anything.

To more closely align with the living standard supported in other browsers, this
CL finally brings supports to shallow values with a new 'Value' column.

Screenshot: http://imgur.com/a/c3afb

BUG=663878
==========

[luoe, 2017-06-02 22:18:17]

ptal

https://codereview.chromium.org/2918993003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
(right):

https://codereview.chromium.org/2918993003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:142:
rowSubProperties = [{name: Common.UIString('Value'), type: rowProperty.type,
value: rowProperty.value}];
On 2017/06/02 22:02:32, dgozman wrote:
> This new column could match one of the properties. Let's follow other browsers
> in this regard.

Yeah, I didn't consider that case.  Done.

[dgozman, 2017-06-02 22:38:57]

lgtm

[luoe, 2017-06-02 22:39:23]

The CQ bit was checked by luoe@chromium.org

[commit-bot: I haz the power, 2017-06-02 22:40:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-03 01:55:00]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496443163116050,
"parent_rev": "8c18f1a1b60f5ad90b3de158558fb65279045e31", "commit_rev":
"f312e41ce160dcb406f68f41b7fa96232efcf48d"}

[commit-bot: I haz the power, 2017-06-03 01:55:11]

Description was changed from

==========
DevTools: allow shallow array values in console.table

Today's console.table() implementation only looks at nested array values
`console.table([[1, 2, 3]])`. It ignores shallow array values, so commands such
as `console.table([1, 2, 3])` will not show anything.

To more closely align with the living standard supported in other browsers, this
CL finally brings supports to shallow values with a new 'Value' column.

Screenshot: http://imgur.com/a/c3afb

BUG=663878
==========

to

==========
DevTools: allow shallow array values in console.table

Today's console.table() implementation only looks at nested array values
`console.table([[1, 2, 3]])`. It ignores shallow array values, so commands such
as `console.table([1, 2, 3])` will not show anything.

To more closely align with the living standard supported in other browsers, this
CL finally brings supports to shallow values with a new 'Value' column.

Screenshot: http://imgur.com/a/c3afb

BUG=663878

Review-Url: https://codereview.chromium.org/2918993003
Cr-Commit-Position: refs/heads/master@{#476852}
Committed:
https://chromium.googlesource.com/chromium/src/+/f312e41ce160dcb406f68f41b7fa...
==========

[commit-bot: I haz the power, 2017-06-03 01:55:12]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f312e41ce160dcb406f68f41b7fa...