Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(980)

Issue 2918853002: Add test for validating the proper size when we exit WebVR to VR browsing. (Closed)

Created:
3 years, 6 months ago by billorr
Modified:
3 years, 6 months ago
Reviewers:
bsheedy, mthiesse, tiborg
CC:
chromium-reviews, feature-vr-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add test for validating the proper size when we exit WebVR to VR browsing. This is an automated test to validate the fix for crbug/718578. BUG=718578 Review-Url: https://codereview.chromium.org/2918853002 Cr-Commit-Position: refs/heads/master@{#476564} Committed: https://chromium.googlesource.com/chromium/src/+/f7b41941ac3c3e7a42d743e5bbae6fe5024edee8

Patch Set 1 #

Total comments: 2

Patch Set 2 : CR feedback #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellNavigationTest.java View 1 2 chunks +33 lines, -0 lines 1 comment Download

Messages

Total messages: 13 (7 generated)
billorr
3 years, 6 months ago (2017-06-01 20:46:31 UTC) #2
bsheedy
LGTM with comment. https://codereview.chromium.org/2918853002/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellNavigationTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellNavigationTest.java (right): https://codereview.chromium.org/2918853002/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellNavigationTest.java#newcode273 chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellNavigationTest.java:273: mVrTestRule.loadUrl(TEST_PAGE_WEBVR_URL, PAGE_LOAD_TIMEOUT_S); Should be loadUrlAndAwaitInitialization to ...
3 years, 6 months ago (2017-06-01 20:52:31 UTC) #3
mthiesse
lgtm
3 years, 6 months ago (2017-06-01 21:10:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2918853002/20001
3 years, 6 months ago (2017-06-02 01:08:43 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/f7b41941ac3c3e7a42d743e5bbae6fe5024edee8
3 years, 6 months ago (2017-06-02 04:31:07 UTC) #11
tiborg
3 years, 6 months ago (2017-06-02 15:36:52 UTC) #13
Message was sent while issue was closed.
https://codereview.chromium.org/2918853002/diff/20001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellNavigationTest.java
(right):

https://codereview.chromium.org/2918853002/diff/20001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellNavigationTest.java:271:
public void testExitPresentationWebVrToVrShell()
This test should probably not be here. VrShellTest would be better. Or a new
test where we test presentation <-> non-presentation, fullscreen <->
non-fullscreen kind of tests.

Powered by Google App Engine
This is Rietveld 408576698