chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java - Issue 2918853002: Add test for validating the proper size when we exit WebVR to VR browsing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

Issue 2918853002: Add test for validating the proper size when we exit WebVR to VR browsing. (Closed)

Patch Set: CR feedback Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellNavigationTest.java » ('j') | chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellNavigationTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

index 9ed4e760e1319239f2763bcc777abbe444553b26..a6f050024d30c02fedbe09b3553f5ee65ad54d5b 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

@@ -66,8 +66,10 @@ public class VrShellImpl

private static final float WEBVR_DPR = 1.0f;

// Fairly arbitrary values that put a good amount of content on the screen without making the

// text too small to read.

- private static final float DEFAULT_CONTENT_WIDTH = 960f;

- private static final float DEFAULT_CONTENT_HEIGHT = 640f;

+ @VisibleForTesting

+ public static final float DEFAULT_CONTENT_WIDTH = 960f;

+ @VisibleForTesting

+ public static final float DEFAULT_CONTENT_HEIGHT = 640f;

// Make full screen 16:9 until we get exact dimensions from playing video.

private static final float FULLSCREEN_CONTENT_WIDTH = 1024f;