Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2918723002: [Merge M60] arc: Fix default app icon for CrossOver app. (Closed)

Created:
3 years, 6 months ago by khmel
Modified:
3 years, 6 months ago
Reviewers:
xiyuan
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

[Merge M60] arc: Fix default app icon for CrossOver app. This CL fixes icon mapping from CrossOver app to shortcut. TEST=Manually + test updated. BUG=726942 BUG=b/62145028 TBR=xiyuan@chromium.org NOTRY=true NOPRESUBMIT=true Change-Id: Ia6bed938cc1ccdb9155d0f88d76f3ed564442330 Reviewed-on: https://chromium-review.googlesource.com/517395 Commit-Queue: Yury Khmel <khmel@google.com>; Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>; Cr-Original-Commit-Position: refs/heads/master@{#475586} Review-Url: https://codereview.chromium.org/2918723002 Cr-Commit-Position: refs/branch-heads/3112@{#69} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/65b97215d37ac6149877dc6f82db86309658bace

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -13 lines) Patch
M chrome/browser/ui/app_list/arc/arc_app_icon.h View 1 chunk +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_icon.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_unittest.cc View 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2918723002/1
3 years, 6 months ago (2017-05-31 23:25:34 UTC) #2
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 23:26:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/65b97215d37ac6149877dc6f82db...

Powered by Google App Engine
This is Rietveld 408576698