Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Unified Diff: chrome/browser/ui/app_list/arc/arc_app_unittest.cc

Issue 2918723002: [Merge M60] arc: Fix default app icon for CrossOver app. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/app_list/arc/arc_app_icon.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/app_list/arc/arc_app_unittest.cc
diff --git a/chrome/browser/ui/app_list/arc/arc_app_unittest.cc b/chrome/browser/ui/app_list/arc/arc_app_unittest.cc
index 919b6be531c9969116eeb326c665d12bcbb221f5..10ac3f8e72c4d469b81b2565fe701e01a8a99b58 100644
--- a/chrome/browser/ui/app_list/arc/arc_app_unittest.cc
+++ b/chrome/browser/ui/app_list/arc/arc_app_unittest.cc
@@ -1199,23 +1199,26 @@ TEST_P(ArcAppModelBuilderTest, IconLoaderForShelfGroup) {
// Shortcut exists, icon is requested from shortcut.
icon_loader.FetchImage(id_shortcut_exist);
- EXPECT_EQ(1UL, delegate.update_image_cnt());
+ // Icon was sent on request and loader should be updated.
+ delegate.WaitForIconUpdates(ui::GetSupportedScaleFactors().size());
EXPECT_EQ(id_shortcut_exist, delegate.app_id());
+
content::RunAllBlockingPoolTasksUntilIdle();
const size_t shortcut_request_cnt =
app_instance()->shortcut_icon_requests().size();
EXPECT_NE(0U, shortcut_request_cnt);
EXPECT_EQ(initial_icon_request_count, app_instance()->icon_requests().size());
- for (const auto& request : app_instance()->shortcut_icon_requests()) {
+ for (const auto& request : app_instance()->shortcut_icon_requests())
EXPECT_EQ(shortcuts[0].icon_resource_id, request->icon_resource_id());
- }
// Fallback when shortcut is not found for shelf group id, use app id instead.
// Remove the IconRequestRecord for |app_id| to observe the icon request for
// |app_id| is re-sent.
+ const size_t update_image_count_before = delegate.update_image_cnt();
MaybeRemoveIconRequestRecord(app_id);
icon_loader.FetchImage(id_shortcut_absent);
- EXPECT_EQ(2UL, delegate.update_image_cnt());
+ // Expected default update.
+ EXPECT_EQ(update_image_count_before + 1, delegate.update_image_cnt());
content::RunAllBlockingPoolTasksUntilIdle();
EXPECT_TRUE(app_instance()->icon_requests().size() >
initial_icon_request_count);
« no previous file with comments | « chrome/browser/ui/app_list/arc/arc_app_icon.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698