Issue 2918653003: Unconditionally delete the unpack path in the UpdateClient.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2918653003: Unconditionally delete the unpack path in the UpdateClient. (Closed)

Created:
3 years, 6 months ago by Sorin Jianu

Modified:
3 years, 6 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3112

Project:
chromium

Visibility:
Public.

Unconditionally delete the unpack path in the UpdateClient. Bug: 726959 Change-Id: I002aa30ee0d85d845dba915d9dbd6e5599218184 Reviewed-on: https://chromium-review.googlesource.com/517463 Reviewed-by: Joshua Pawlicki <waffles@chromium.org>; Commit-Queue: Sorin Jianu <sorin@chromium.org>; Cr-Original-Commit-Position: refs/heads/master@{#475648} Review-Url: https://codereview.chromium.org/2918653003 . Cr-Commit-Position: refs/branch-heads/3112@{#65} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/993e502cb59a07df852caf1d6c940c998b71f04f

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -10 lines)			Patch
M	components/update_client/component.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	components/update_client/test_installer.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	components/update_client/test_installer.cc	View	3 chunks	+11 lines, -5 lines	0 comments	Download
M	components/update_client/update_client_unittest.cc	View	2 chunks	+16 lines, -5 lines	0 comments	Download

Total messages: 2 (1 generated)

Sorin Jianu

3 years, 6 months ago (2017-05-31 21:55:31 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
993e502cb59a07df852caf1d6c940c998b71f04f.