Unconditionally delete the unpack path in the UpdateClient.

components/update_client/test_installer.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/update_client/test_installer.h"
 
 #include <string>
 
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/values.h"
 #include "components/update_client/update_client_errors.h"
+#include "testing/gtest/include/gtest/gtest.h"
 
 namespace update_client {
 
 TestInstaller::TestInstaller() : error_(0), install_count_(0) {
 }
 
+TestInstaller::~TestInstaller() {
+  // The unpack path is deleted unconditionally by the component state code,
+  // which is driving this installer. Therefore, the unpack path must not
+  // exist when this object is destroyed.
+  if (!unpack_path_.empty())
+    EXPECT_FALSE(base::DirectoryExists(unpack_path_));
+}
+
 void TestInstaller::OnUpdateError(int error) {
   error_ = error;
 }
 
 CrxInstaller::Result TestInstaller::Install(
     const base::DictionaryValue& manifest,
     const base::FilePath& unpack_path) {
   ++install_count_;
-  if (!base::DeleteFile(unpack_path, true))
-    return Result(InstallError::GENERIC_ERROR);
+
+  unpack_path_ = unpack_path;
 
   return Result(InstallError::NONE);
 }
 
 bool TestInstaller::GetInstalledFile(const std::string& file,
                                      base::FilePath* installed_file) {
   return false;
 }
 
-TestInstaller::~TestInstaller() {
-}
-
 bool TestInstaller::Uninstall() {
   return false;
 }
 
 ReadOnlyTestInstaller::ReadOnlyTestInstaller(const base::FilePath& install_dir)
     : install_directory_(install_dir) {
 }
 
 ReadOnlyTestInstaller::~ReadOnlyTestInstaller() {
 }
@@ skipping 31 matching lines @@
 
 bool VersionedTestInstaller::GetInstalledFile(const std::string& file,
                                               base::FilePath* installed_file) {
   base::FilePath path;
   path = install_directory_.AppendASCII(current_version_.GetString());
   *installed_file = path.Append(base::FilePath::FromUTF8Unsafe(file));
   return true;
 }
 
 }  // namespace update_client