[Media Router tests] Fix MANUAL_Fail_StartCancelledNoSupportedSinks.

[Media Router tests] Fix MANUAL_Fail_StartCancelledNoSupportedSinks.

With recent changes to the dialog initiated from Presentation API, we
no longer show sinks that are not compatible with the
PresentationRequest. This patch adjusts expectations accordingly.

Also rename the OneUA tests so they get run by the mr bot.

BUG=727782
Review-Url: https://codereview.chromium.org/2918433002
Cr-Commit-Position: refs/heads/master@{#476099}
Committed: https://chromium.googlesource.com/chromium/src/+/62cd7edbac71dea25995b1ec220b149add0539c4

[imcheng, 2017-05-31 01:15:32]

imcheng@chromium.org changed reviewers:
+ mfoltz@chromium.org, zhaobin@chromium.org

[imcheng, 2017-05-31 01:15:33]

PTAL:

zhaobin@: everything
mfoltz@: everything + committers

[mark a. foltz, 2017-05-31 21:35:24]

lgtm

https://codereview.chromium.org/2918433002/diff/40001/chrome/test/media_route...
File chrome/test/media_router/media_router_integration_browsertest.cc (right):

https://codereview.chromium.org/2918433002/diff/40001/chrome/test/media_route...
chrome/test/media_router/media_router_integration_browsertest.cc:172: // Wait a
bit for the UI to settle.
I think the logic to reject the start() promise in the MRUI doesn't require the
dialog to be fully rendered.  Is the "UI settling" required for
HideMediaRouterDialog() to work?

[imcheng, 2017-05-31 21:49:02]

https://codereview.chromium.org/2918433002/diff/40001/chrome/test/media_route...
File chrome/test/media_router/media_router_integration_browsertest.cc (right):

https://codereview.chromium.org/2918433002/diff/40001/chrome/test/media_route...
chrome/test/media_router/media_router_integration_browsertest.cc:172: // Wait a
bit for the UI to settle.
On 2017/05/31 21:35:23, mark a. foltz wrote:
> I think the logic to reject the start() promise in the MRUI doesn't require
the
> dialog to be fully rendered.  Is the "UI settling" required for
> HideMediaRouterDialog() to work?

The purpose of the Wait is to try to make sure that there are indeed no sinks
returned to the UI asynchronously. If we closed the UI too soon then we might
miss sinks that would've otherwise shown up.

[imcheng, 2017-05-31 22:22:13]

Description was changed from

==========
[Media Router tests] Fix MANUAL_Fail_StartCancelledNoSupportedSinks.

With recent changes to the dialog initiated from Presentation API, we
no longer show sinks that are not compatible with the
PresentationRequest. This patch adjusts expectations accordingly.

BUG=727782
==========

to

==========
[Media Router tests] Fix MANUAL_Fail_StartCancelledNoSupportedSinks.

With recent changes to the dialog initiated from Presentation API, we
no longer show sinks that are not compatible with the
PresentationRequest. This patch adjusts expectations accordingly.

Also rename the OneUA tests so they get run by the mr bot.

BUG=727782
==========

[mark a. foltz, 2017-05-31 22:54:20]

Ah, got it.

https://codereview.chromium.org/2918433002/diff/60001/chrome/test/media_route...
File chrome/test/media_router/media_router_integration_browsertest.cc (right):

https://codereview.chromium.org/2918433002/diff/60001/chrome/test/media_route...
chrome/test/media_router/media_router_integration_browsertest.cc:172: // Wait a
bit for the UI to settle.
Maybe update this to "Wait for any sinks to be displayed."

[imcheng, 2017-05-31 23:12:27]

https://codereview.chromium.org/2918433002/diff/60001/chrome/test/media_route...
File chrome/test/media_router/media_router_integration_browsertest.cc (right):

https://codereview.chromium.org/2918433002/diff/60001/chrome/test/media_route...
chrome/test/media_router/media_router_integration_browsertest.cc:172: // Wait a
bit for the UI to settle.
On 2017/05/31 22:54:20, mark a. foltz wrote:
> Maybe update this to "Wait for any sinks to be displayed."

Done.

[imcheng, 2017-05-31 23:12:31]

The CQ bit was checked by imcheng@chromium.org

[imcheng, 2017-05-31 23:12:31]

The patchset sent to the CQ was uploaded after l-g-t-m from mfoltz@chromium.org
Link to the patchset: https://codereview.chromium.org/2918433002/#ps80001
(title: "Update comments")

[commit-bot: I haz the power, 2017-05-31 23:13:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 23:55:49]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1496272351053390,
"parent_rev": "948a6f1c5a71a794d102c28367ee64c5c81b2f3e", "commit_rev":
"62cd7edbac71dea25995b1ec220b149add0539c4"}

[commit-bot: I haz the power, 2017-05-31 23:55:57]

Description was changed from

==========
[Media Router tests] Fix MANUAL_Fail_StartCancelledNoSupportedSinks.

With recent changes to the dialog initiated from Presentation API, we
no longer show sinks that are not compatible with the
PresentationRequest. This patch adjusts expectations accordingly.

Also rename the OneUA tests so they get run by the mr bot.

BUG=727782
==========

to

==========
[Media Router tests] Fix MANUAL_Fail_StartCancelledNoSupportedSinks.

With recent changes to the dialog initiated from Presentation API, we
no longer show sinks that are not compatible with the
PresentationRequest. This patch adjusts expectations accordingly.

Also rename the OneUA tests so they get run by the mr bot.

BUG=727782

Review-Url: https://codereview.chromium.org/2918433002
Cr-Commit-Position: refs/heads/master@{#476099}
Committed:
https://chromium.googlesource.com/chromium/src/+/62cd7edbac71dea25995b1ec220b...
==========

[commit-bot: I haz the power, 2017-05-31 23:55:58]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/62cd7edbac71dea25995b1ec220b...