[Media Router tests] Add minimal ScopedAllowIO for the tests to pass.

[Media Router tests] Add minimal ScopedAllowIO for the tests to pass.

In MR integration tests we perform certain file IO for loading test
data. As IO restrictions are now enforced in browser_tests, we need
to use ScopedAllowIO to bypass them.

Also added media_router_integration_browsertest.cc to the ScopedAllowIO
whitelist.

BUG=724573
Review-Url: https://codereview.chromium.org/2910263002
Cr-Commit-Position: refs/heads/master@{#476010}
Committed: https://chromium.googlesource.com/chromium/src/+/a7e23ba097190eb75739fe1687002696b5962853

[imcheng, 2017-05-30 19:16:13]

Patchset #1 (id:1) has been deleted

[imcheng, 2017-05-30 19:17:57]

imcheng@chromium.org changed reviewers:
+ jam@chromium.org, zhaobin@chromium.org

[imcheng, 2017-05-30 19:17:58]

Reviewers, PTAL:

jam@: PRESUBMIT.py
zhaobin@: *.cc

Thanks!

[zhaobin, 2017-05-30 20:41:00]

lgtm

May need to add "base::ThreadRestrictions::ScopedAllowIO allow_io;" to
media_router_one_ua_integration_browsertest.cc as well.

[imcheng, 2017-05-30 23:44:29]

On 2017/05/30 20:41:00, zhaobin wrote:
> lgtm
> 
> May need to add "base::ThreadRestrictions::ScopedAllowIO allow_io;" to
> media_router_one_ua_integration_browsertest.cc as well.

I test locally and it seems the OneUA tests will not need ScopedAllowIO.

[mark a. foltz, 2017-05-30 23:50:03]

mfoltz@chromium.org changed reviewers:
+ mfoltz@chromium.org

[mark a. foltz, 2017-05-30 23:50:04]

Do you also need this fix for MediaRouterBaseBrowserTest::ParseCommandLine?

https://codereview.chromium.org/2910263002/diff/40001/chrome/test/media_route...
File chrome/test/media_router/media_router_integration_browsertest.cc (right):

https://codereview.chromium.org/2910263002/diff/40001/chrome/test/media_route...
chrome/test/media_router/media_router_integration_browsertest.cc:284:
base::ThreadRestrictions::ScopedAllowIO allow_io;
I don't see anything in this stack frame that requires IO.
Did I miss something?

https://codereview.chromium.org/2910263002/diff/40001/chrome/test/media_route...
chrome/test/media_router/media_router_integration_browsertest.cc:319:
base::ThreadRestrictions::ScopedAllowIO allow_io;
Can this be scoped to only include PathExists?

[jam, 2017-05-31 00:22:54]

rs lgtm to whatever lines you need in the presubmit

[imcheng, 2017-05-31 00:29:57]

On 2017/05/30 23:50:04, mark a. foltz wrote:
> Do you also need this fix for MediaRouterBaseBrowserTest::ParseCommandLine?
> 

Apparently not, as the tests ran fine without it. It seems the IO restriction
does not apply during SetUp. 


>
https://codereview.chromium.org/2910263002/diff/40001/chrome/test/media_route...
> File chrome/test/media_router/media_router_integration_browsertest.cc (right):
> 
>
https://codereview.chromium.org/2910263002/diff/40001/chrome/test/media_route...
> chrome/test/media_router/media_router_integration_browsertest.cc:284:
> base::ThreadRestrictions::ScopedAllowIO allow_io;
> I don't see anything in this stack frame that requires IO.
> Did I miss something?
> 
>
https://codereview.chromium.org/2910263002/diff/40001/chrome/test/media_route...
> chrome/test/media_router/media_router_integration_browsertest.cc:319:
> base::ThreadRestrictions::ScopedAllowIO allow_io;
> Can this be scoped to only include PathExists?

[imcheng, 2017-05-31 00:30:22]

https://codereview.chromium.org/2910263002/diff/40001/chrome/test/media_route...
File chrome/test/media_router/media_router_integration_browsertest.cc (right):

https://codereview.chromium.org/2910263002/diff/40001/chrome/test/media_route...
chrome/test/media_router/media_router_integration_browsertest.cc:284:
base::ThreadRestrictions::ScopedAllowIO allow_io;
On 2017/05/30 23:50:04, mark a. foltz wrote:
> I don't see anything in this stack frame that requires IO.
> Did I miss something?

JSONFileValueDeserializer::Deserialize requires it. I scoped allow_io to only
that call.

https://codereview.chromium.org/2910263002/diff/40001/chrome/test/media_route...
chrome/test/media_router/media_router_integration_browsertest.cc:319:
base::ThreadRestrictions::ScopedAllowIO allow_io;
On 2017/05/30 23:50:03, mark a. foltz wrote:
> Can this be scoped to only include PathExists?

Done.

[mark a. foltz, 2017-05-31 15:57:53]

lgtm

[imcheng, 2017-05-31 17:24:09]

The CQ bit was checked by imcheng@chromium.org

[imcheng, 2017-05-31 17:24:10]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org,
zhaobin@chromium.org
Link to the patchset: https://codereview.chromium.org/2910263002/#ps60001
(title: "Addressed Mark's comments")

[commit-bot: I haz the power, 2017-05-31 17:24:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 17:31:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 17:31:30]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[imcheng, 2017-05-31 19:10:19]

The CQ bit was checked by imcheng@chromium.org

[commit-bot: I haz the power, 2017-05-31 19:11:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 20:46:28]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1496257819638550,
"parent_rev": "5a3e83f7ad2b0155533bc23b0f753a80522125b4", "commit_rev":
"a7e23ba097190eb75739fe1687002696b5962853"}

[commit-bot: I haz the power, 2017-05-31 20:46:39]

Description was changed from

==========
[Media Router tests] Add minimal ScopedAllowIO for the tests to pass.

In MR integration tests we perform certain file IO for loading test
data. As IO restrictions are now enforced in browser_tests, we need
to use ScopedAllowIO to bypass them.

Also added media_router_integration_browsertest.cc to the ScopedAllowIO
whitelist.

BUG=724573
==========

to

==========
[Media Router tests] Add minimal ScopedAllowIO for the tests to pass.

In MR integration tests we perform certain file IO for loading test
data. As IO restrictions are now enforced in browser_tests, we need
to use ScopedAllowIO to bypass them.

Also added media_router_integration_browsertest.cc to the ScopedAllowIO
whitelist.

BUG=724573

Review-Url: https://codereview.chromium.org/2910263002
Cr-Commit-Position: refs/heads/master@{#476010}
Committed:
https://chromium.googlesource.com/chromium/src/+/a7e23ba097190eb75739fe168700...
==========

[commit-bot: I haz the power, 2017-05-31 20:46:40]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/a7e23ba097190eb75739fe168700...