Move [Provisional]DataSource accessors/methods from WebFrame to WebLocalFrame.

Move [Provisional]DataSource accessors/methods from WebFrame to WebLocalFrame.

BUG=416660
TBR=mmenke@chromium.org

Review-Url: https://codereview.chromium.org/2918403003
Cr-Commit-Position: refs/heads/master@{#477467}
Committed: https://chromium.googlesource.com/chromium/src/+/2f44efa154b72b33fe9ebb543e0e83785a4c8058

[Łukasz Anforowicz, 2017-06-05 23:35:03]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-05 23:35:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 01:48:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 01:48:18]

Dry run: This issue passed the CQ dry run.

[Łukasz Anforowicz, 2017-06-06 18:32:37]

lukasza@chromium.org changed reviewers:
+ dcheng@chromium.org

[Łukasz Anforowicz, 2017-06-06 18:32:37]

dcheng@, can you PTAL?

[dcheng, 2017-06-06 18:49:53]

lgtm

https://codereview.chromium.org/2918403003/diff/1/content/renderer/render_fra...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/2918403003/diff/1/content/renderer/render_fra...
content/renderer/render_frame_impl.cc:3328:
webview->MainFrame()->ToWebLocalFrame()->DataSource()) {
I guess this doesn't work at all in OOPIF =/

[Łukasz Anforowicz, 2017-06-06 19:31:46]

https://codereview.chromium.org/2918403003/diff/1/content/renderer/render_fra...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/2918403003/diff/1/content/renderer/render_fra...
content/renderer/render_frame_impl.cc:3328:
webview->MainFrame()->ToWebLocalFrame()->DataSource()) {
On 2017/06/06 18:49:53, dcheng wrote:
> I guess this doesn't work at all in OOPIF =/

Hmmm... to be honest, I was just trying to preserve the existing behavior here
and I don't really understand what is going on here and how to make it right. 
Since you seem to understand this better than me - do you think this is worthy
of a separate bug?

[dcheng, 2017-06-06 20:03:02]

On 2017/06/06 19:31:46, Łukasz A. wrote:
>
https://codereview.chromium.org/2918403003/diff/1/content/renderer/render_fra...
> File content/renderer/render_frame_impl.cc (right):
> 
>
https://codereview.chromium.org/2918403003/diff/1/content/renderer/render_fra...
> content/renderer/render_frame_impl.cc:3328:
> webview->MainFrame()->ToWebLocalFrame()->DataSource()) {
> On 2017/06/06 18:49:53, dcheng wrote:
> > I guess this doesn't work at all in OOPIF =/
> 
> Hmmm... to be honest, I was just trying to preserve the existing behavior here
> and I don't really understand what is going on here and how to make it right. 
> Since you seem to understand this better than me - do you think this is worthy
> of a separate bug?

Yeah, I would consider this a separate bug. Maybe let's just add a TODO (it
seems fixing it is out of scope of these CLs).

[Łukasz Anforowicz, 2017-06-06 21:10:11]

On 2017/06/06 20:03:02, dcheng wrote:
> On 2017/06/06 19:31:46, Łukasz A. wrote:
> >
>
https://codereview.chromium.org/2918403003/diff/1/content/renderer/render_fra...
> > File content/renderer/render_frame_impl.cc (right):
> > 
> >
>
https://codereview.chromium.org/2918403003/diff/1/content/renderer/render_fra...
> > content/renderer/render_frame_impl.cc:3328:
> > webview->MainFrame()->ToWebLocalFrame()->DataSource()) {
> > On 2017/06/06 18:49:53, dcheng wrote:
> > > I guess this doesn't work at all in OOPIF =/
> > 
> > Hmmm... to be honest, I was just trying to preserve the existing behavior
here
> > and I don't really understand what is going on here and how to make it
right. 
> > Since you seem to understand this better than me - do you think this is
worthy
> > of a separate bug?
> 
> Yeah, I would consider this a separate bug. Maybe let's just add a TODO (it
> seems fixing it is out of scope of these CLs).

I've found an existing bug and added a TODO here.

[Łukasz Anforowicz, 2017-06-06 21:10:40]

The CQ bit was checked by lukasza@chromium.org

[Łukasz Anforowicz, 2017-06-06 21:10:40]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2918403003/#ps20001
(title: "Added a TODO comment for user agent overrides -
https://crbug.com/426555")

[Łukasz Anforowicz, 2017-06-06 21:11:02]

The CQ bit was unchecked by lukasza@chromium.org

[Łukasz Anforowicz, 2017-06-06 21:12:06]

lukasza@chromium.org changed reviewers:
+ avi@chromium.org

[Łukasz Anforowicz, 2017-06-06 21:12:07]

avi@, can you PTAL?

[Łukasz Anforowicz, 2017-06-06 21:34:37]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-06 21:35:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2017-06-06 22:55:29]

lgtm

[commit-bot: I haz the power, 2017-06-06 23:40:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 23:40:27]

Dry run: This issue passed the CQ dry run.

[Łukasz Anforowicz, 2017-06-06 23:43:31]

Description was changed from

==========
Move [Provisional]DataSource accessors/methods from WebFrame to WebLocalFrame.

BUG=416660
==========

to

==========
Move [Provisional]DataSource accessors/methods from WebFrame to WebLocalFrame.

BUG=416660
TBR=mmenke@chromium.org
==========

[Łukasz Anforowicz, 2017-06-06 23:44:07]

Thanks.  I'll go ahead and push this CL to CQ (TBR-ing mmenke@ for the simple
change in chrome/renderer/net/net_error_helper.cc).

[Łukasz Anforowicz, 2017-06-06 23:44:41]

lukasza@chromium.org changed reviewers:
+ mmenke@chromium.org

[Łukasz Anforowicz, 2017-06-06 23:44:43]

Actually adding / TBR-ing mmenke@ this time :-)

[Łukasz Anforowicz, 2017-06-06 23:44:47]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2017-06-06 23:45:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 23:49:54]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496792687930060,
"parent_rev": "97bec63d0193db10f8e31fdad38ea8886d73e00f", "commit_rev":
"2f44efa154b72b33fe9ebb543e0e83785a4c8058"}

[commit-bot: I haz the power, 2017-06-06 23:50:05]

Description was changed from

==========
Move [Provisional]DataSource accessors/methods from WebFrame to WebLocalFrame.

BUG=416660
TBR=mmenke@chromium.org
==========

to

==========
Move [Provisional]DataSource accessors/methods from WebFrame to WebLocalFrame.

BUG=416660
TBR=mmenke@chromium.org

Review-Url: https://codereview.chromium.org/2918403003
Cr-Commit-Position: refs/heads/master@{#477467}
Committed:
https://chromium.googlesource.com/chromium/src/+/2f44efa154b72b33fe9ebb543e0e...
==========

[commit-bot: I haz the power, 2017-06-06 23:50:07]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2f44efa154b72b33fe9ebb543e0e...