third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp - Issue 2918403003: Move [Provisional]DataSource accessors/methods from WebFrame to WebLocalFrame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

Issue 2918403003: Move [Provisional]DataSource accessors/methods from WebFrame to WebLocalFrame. (Closed)

Patch Set: Added a TODO comment for user agent overrides - https://crbug.com/426555 Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp b/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

index 556afc8a7029dceadc6b8ea95c48f6ad03488dae..4eff8edbb1a5ec2c431dc60e93c184d86428c8d6 100644

--- a/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

+++ b/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

@@ -216,16 +216,6 @@ void WebRemoteFrameImpl::StopLoading() {

// in all subframes, both remote and local.

}

-WebDataSource* WebRemoteFrameImpl::ProvisionalDataSource() const {

- NOTREACHED();

- return nullptr;

-WebDataSource* WebRemoteFrameImpl::DataSource() const {

- NOTREACHED();

- return nullptr;

void WebRemoteFrameImpl::EnableViewSourceMode(bool enable) {

NOTREACHED();

}