Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 2918263002: Revert of cc: Don't use StreamVideoDrawQuad on any platform but Android. (patchset #3 id:40001 of h… (Closed)

Created:
3 years, 6 months ago by Pawel Osciak
Modified:
3 years, 6 months ago
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Don't use StreamVideoDrawQuad on any platform but Android. (patchset #3 id:40001 of https://codereview.chromium.org/2763223003/ ) Reason for revert: crbug.com/724812 Original issue's description: > cc: Don't use StreamVideoDrawQuad on any platform but Android. > > VideoLayerImpl is appending StreamVideoDrawQuads on CrOS. > > StreamVideoDrawQuads should be used on Android since almost all its > features are supported by TextureDrawQuad. > The only difference is that StreamVideoDrawQuad calls > glUniformMatrix4fvStreamTextureMatrixCHROMIUM before drawing, that > just sets a uniform matrix on CrOS. > > This CL makes sure VideoLayerImpl produces StreamVideoDrawQuads only > on Android. > > BUG=702750 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel > > Review-Url: https://codereview.chromium.org/2763223003 > Cr-Commit-Position: refs/heads/master@{#460547} > Committed: https://chromium.googlesource.com/chromium/src/+/517d0115d3c435383f79a0b730b6514a6cc97f44 TBR=danakj@chromium.org,reveman@chromium.org,avi@chromium.org,dcastagna@chromium.org BUG=702750 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2920893003 Cr-Original-Commit-Position: refs/heads/master@{#476523} Review-Url: https://codereview.chromium.org/2918263002 . Cr-Commit-Position: refs/branch-heads/3112@{#137} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/1789c4c2475ad846783e5272dc963dd4dacc942a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -89 lines) Patch
M cc/layers/video_layer_impl.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M cc/output/renderer_pixeltest.cc View 2 chunks +7 lines, -10 lines 0 comments Download
M cc/resources/video_resource_updater.h View 2 chunks +1 line, -3 lines 0 comments Download
M cc/resources/video_resource_updater.cc View 4 chunks +7 lines, -12 lines 0 comments Download
M cc/resources/video_resource_updater_unittest.cc View 14 chunks +13 lines, -58 lines 0 comments Download
M cc/trees/layer_tree_settings.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Pawel Osciak
3 years, 6 months ago (2017-06-05 01:43:41 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1789c4c2475ad846783e5272dc963dd4dacc942a.

Powered by Google App Engine
This is Rietveld 408576698