mash: Make ShelfWindowWatcher items for unknown windows.

mash: Make ShelfWindowWatcher items for unknown windows.

Restore some ShelfWindowWatcher functionality for Mash:
Assign default shelf ids and item types to windows.
(respect the WindowState::ignored_by_shelf flag)
(use TYPE_DIALOG to avoid Chrome setting an icon, etc.)
(ignore windows with transient parents)
Update the items if an app (ie. Chrome) claims the windows.

Inline GetShelfItemIndexForWindow helper function.
Improve ShelfController and CLC logging.
Add transient, ignored_by_shelf, and mash unit tests.

TODO: Make ignored_by_shelf a window property to fix observation.
(WindowState changes don't notify; StatusBubble gets an item...)

BUG=557406, 729425
TEST=chrome --mash shows a shelf item for QuickLaunch.
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2918223002
Cr-Commit-Position: refs/heads/master@{#476922}
Committed: https://chromium.googlesource.com/chromium/src/+/70ac45fc6ef3bc0acb2260a5aba251a13afd6f15

[msw, 2017-06-02 20:45:34]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 20:46:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 20:49:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 20:49:31]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[msw, 2017-06-02 20:55:26]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 20:55:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 22:08:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 22:08:08]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[msw, 2017-06-02 23:10:39]

Description was changed from

==========
mash: Make ShelfWindowWatcher items for unknown windows.

BUG=557406
TEST=chrome --mash shows a shelf item for QuickLaunch.
R=sky@chromium.org
==========

to

==========
mash: Make ShelfWindowWatcher items for unknown windows.

Restore some ShelfWindowWatcher functionality for Mash:
Assign default shelf ids and item types to windows.
(respect the WindowState::ignored_by_shelf flag)
(use TYPE_DIALOG to avoid Chrome setting an icon, etc.)
(ignore windows with transient parents)
Update the items if an app (ie. Chrome) claims the windows.

Inline GetShelfItemIndexForWindow helper function.
Improve ShelfController and CLC logging.
Add transient, ignored_by_shelf, and mash unit tests.

TODO: Make ignored_by_shelf a window property to fix observation.
(WindowState changes don't notify; StatusBubble gets an item...)

BUG=557406
TEST=chrome --mash shows a shelf item for QuickLaunch.
R=sky@chromium.org
==========

[msw, 2017-06-02 23:11:50]

Patchset #4 (id:2) has been deleted

[msw, 2017-06-02 23:11:54]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 23:12:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2017-06-02 23:12:49]

Hey Scott, please take a look; thanks!
( replaces https://codereview.chromium.org/2915223002 )
( lmk if you'd rather ask James to review this change )

[sky, 2017-06-02 23:37:16]

LGTM

[sky, 2017-06-02 23:46:40]

One comment, LGTM with it addressed.

https://codereview.chromium.org/2918223002/diff/70001/ash/shelf/shelf_window_...
File ash/shelf/shelf_window_watcher.cc (right):

https://codereview.chromium.org/2918223002/diff/70001/ash/shelf/shelf_window_...
ash/shelf/shelf_window_watcher.cc:54: const ash::ShelfID
shelf_id("ShelfWindowWatcher" + base::IntToString(id++));
Current thinking is std::to_string is the better way to convert ints to string.

[commit-bot: I haz the power, 2017-06-03 00:02:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-03 00:02:03]

Dry run: This issue passed the CQ dry run.

[msw, 2017-06-03 00:25:32]

https://codereview.chromium.org/2918223002/diff/70001/ash/shelf/shelf_window_...
File ash/shelf/shelf_window_watcher.cc (right):

https://codereview.chromium.org/2918223002/diff/70001/ash/shelf/shelf_window_...
ash/shelf/shelf_window_watcher.cc:54: const ash::ShelfID
shelf_id("ShelfWindowWatcher" + base::IntToString(id++));
On 2017/06/02 23:46:40, sky wrote:
> Current thinking is std::to_string is the better way to convert ints to
string.

Done. Thanks for the tip!

[msw, 2017-06-03 00:25:40]

The CQ bit was checked by msw@chromium.org

[msw, 2017-06-03 00:25:40]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2918223002/#ps90001
(title: "Address comment.")

[commit-bot: I haz the power, 2017-06-03 00:26:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-03 01:33:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-03 01:33:43]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[msw, 2017-06-03 03:47:43]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2017-06-03 03:47:53]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-03 04:48:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-03 04:48:45]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[msw, 2017-06-04 21:37:50]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2017-06-04 21:37:58]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-04 22:28:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-04 22:28:22]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[msw, 2017-06-05 00:33:24]

Description was changed from

==========
mash: Make ShelfWindowWatcher items for unknown windows.

Restore some ShelfWindowWatcher functionality for Mash:
Assign default shelf ids and item types to windows.
(respect the WindowState::ignored_by_shelf flag)
(use TYPE_DIALOG to avoid Chrome setting an icon, etc.)
(ignore windows with transient parents)
Update the items if an app (ie. Chrome) claims the windows.

Inline GetShelfItemIndexForWindow helper function.
Improve ShelfController and CLC logging.
Add transient, ignored_by_shelf, and mash unit tests.

TODO: Make ignored_by_shelf a window property to fix observation.
(WindowState changes don't notify; StatusBubble gets an item...)

BUG=557406
TEST=chrome --mash shows a shelf item for QuickLaunch.
R=sky@chromium.org
==========

to

==========
mash: Make ShelfWindowWatcher items for unknown windows.

Restore some ShelfWindowWatcher functionality for Mash:
Assign default shelf ids and item types to windows.
(respect the WindowState::ignored_by_shelf flag)
(use TYPE_DIALOG to avoid Chrome setting an icon, etc.)
(ignore windows with transient parents)
Update the items if an app (ie. Chrome) claims the windows.

Inline GetShelfItemIndexForWindow helper function.
Improve ShelfController and CLC logging.
Add transient, ignored_by_shelf, and mash unit tests.

TODO: Make ignored_by_shelf a window property to fix observation.
(WindowState changes don't notify; StatusBubble gets an item...)

BUG=557406,729425
TEST=chrome --mash shows a shelf item for QuickLaunch.
R=sky@chromium.org
==========

[msw, 2017-06-05 00:35:03]

I'm disabling ExperimentalAppWindowApiTest.SetIcon in mash_browser_tests for now
to land this cl.
I think the usability gain is worth a temporary test coverage regression. I
filed http://crbug.com/729425 and I'll look into the failure and get the test
running again soon.

[msw, 2017-06-05 00:35:09]

The CQ bit was checked by msw@chromium.org

[msw, 2017-06-05 00:35:09]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2918223002/#ps110001
(title: "Disable failing mash browser test for now.")

[commit-bot: I haz the power, 2017-06-05 00:35:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-05 02:02:48]

CQ is committing da patch.

Bot data: {"patchset_id": 110001, "attempt_start_ts": 1496622909426440,
"parent_rev": "ba2ff9ad0d643a443575c839e56ae9edf7106643", "commit_rev":
"70ac45fc6ef3bc0acb2260a5aba251a13afd6f15"}

[commit-bot: I haz the power, 2017-06-05 02:02:56]

Description was changed from

==========
mash: Make ShelfWindowWatcher items for unknown windows.

Restore some ShelfWindowWatcher functionality for Mash:
Assign default shelf ids and item types to windows.
(respect the WindowState::ignored_by_shelf flag)
(use TYPE_DIALOG to avoid Chrome setting an icon, etc.)
(ignore windows with transient parents)
Update the items if an app (ie. Chrome) claims the windows.

Inline GetShelfItemIndexForWindow helper function.
Improve ShelfController and CLC logging.
Add transient, ignored_by_shelf, and mash unit tests.

TODO: Make ignored_by_shelf a window property to fix observation.
(WindowState changes don't notify; StatusBubble gets an item...)

BUG=557406,729425
TEST=chrome --mash shows a shelf item for QuickLaunch.
R=sky@chromium.org
==========

to

==========
mash: Make ShelfWindowWatcher items for unknown windows.

Restore some ShelfWindowWatcher functionality for Mash:
Assign default shelf ids and item types to windows.
(respect the WindowState::ignored_by_shelf flag)
(use TYPE_DIALOG to avoid Chrome setting an icon, etc.)
(ignore windows with transient parents)
Update the items if an app (ie. Chrome) claims the windows.

Inline GetShelfItemIndexForWindow helper function.
Improve ShelfController and CLC logging.
Add transient, ignored_by_shelf, and mash unit tests.

TODO: Make ignored_by_shelf a window property to fix observation.
(WindowState changes don't notify; StatusBubble gets an item...)

BUG=557406,729425
TEST=chrome --mash shows a shelf item for QuickLaunch.
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2918223002
Cr-Commit-Position: refs/heads/master@{#476922}
Committed:
https://chromium.googlesource.com/chromium/src/+/70ac45fc6ef3bc0acb2260a5aba2...
==========

[commit-bot: I haz the power, 2017-06-05 02:02:58]

Committed patchset #6 (id:110001) as
https://chromium.googlesource.com/chromium/src/+/70ac45fc6ef3bc0acb2260a5aba2...