mash: Fix mash app shelf items; encapsulate ash property setup.

ABANDONED IN FAVOR OF https://codereview.chromium.org/2918223002

mash: Fix mash app shelf items; encapsulate ash property setup.

Add ash::RegisterWindowPropertiesForTransportAndMirroring()
(allows mus clients to setup window properties for transport)

Call this from Chrome, QuickLaunch, other mash apps.
Set QuickLaunch, etc. properties to show on the shelf.
note: 'window_type_launcher' & 'task_viewer' don't launch on ToT.

Make ShowExamplesWindow return a widget for client use.

OPTIONAL: Use the new function in ash::WindowManager's ctor?
TODO: Fix QuickLaunch ShelfButtons ink-drop crash on 2nd click.

BUG=557406
TEST=chrome --mash shows a shelf item for QuickLaunch.
R=sky@chromium.org

[msw, 2017-06-01 22:37:49]

Description was changed from

==========
mash: Fix QuickLaunch shelf item; encapsulate ash property setup.

BUG=557406
TEST=chrome --mash shows a shelf item for QuickLaunch.
R=sky@chromium.org
==========

to

==========
mash: Fix mash app shelf items; encapsulate ash property setup.

BUG=557406
TEST=chrome --mash shows a shelf item for QuickLaunch.
R=sky@chromium.org
==========

[msw, 2017-06-01 23:34:46]

Description was changed from

==========
mash: Fix mash app shelf items; encapsulate ash property setup.

BUG=557406
TEST=chrome --mash shows a shelf item for QuickLaunch.
R=sky@chromium.org
==========

to

==========
mash: Fix mash app shelf items; encapsulate ash property setup.

Add ash::RegisterWindowPropertiesForTransportAndMirroring()
(allows mus clients to setup window properties for transport)

Call this from Chrome, QuickLaunch, other mash apps.
Set QuickLaunch, etc. properties to show on the shelf.
note: 'window_type_launcher' & 'task_viewer' don't launch on ToT.

Make ShowExamplesWindow return a widget for client use.

OPTIONAL: Use the new function in ash::WindowManager's ctor?
TODO: Fix QuickLaunch ShelfButtons ink-drop crash on 2nd click.

BUG=557406
TEST=chrome --mash shows a shelf item for QuickLaunch.
R=sky@chromium.org
==========

[msw, 2017-06-01 23:35:27]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[msw, 2017-06-01 23:35:41]

Hey Scott, please take a look; thanks!

https://codereview.chromium.org/2915223002/diff/20001/mash/example/window_typ...
File mash/example/window_type_launcher/window_type_launcher.cc (right):

https://codereview.chromium.org/2915223002/diff/20001/mash/example/window_typ...
mash/example/window_type_launcher/window_type_launcher.cc:484: const
ash::ShelfID shelf_id("org.chromium.mash.window_type_launcher");
q: I can't actually launch this from chrome --mash ToT; should I skip it?

https://codereview.chromium.org/2915223002/diff/20001/mash/task_viewer/task_v...
File mash/task_viewer/task_viewer.cc (right):

https://codereview.chromium.org/2915223002/diff/20001/mash/task_viewer/task_v...
mash/task_viewer/task_viewer.cc:335: const ash::ShelfID
shelf_id("org.chromium.mash.task_viewer");
q: I can't actually launch this from chrome --mash ToT; should I skip it?

[commit-bot: I haz the power, 2017-06-01 23:36:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 01:31:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 01:31:25]

Dry run: This issue passed the CQ dry run.

[sky, 2017-06-02 13:36:39]

https://codereview.chromium.org/2915223002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc (left):

https://codereview.chromium.org/2915223002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc:68:
ash::kShelfIDKey, ui::mojom::WindowManager::kShelfID_Property);
Ideally clients would not have to do anything special to have their windows
appear in the shelf. What would it take to make that happen? Say for example
having task viewers window appear in the shelf without having task view
explicitly set the type and shelf id.

[msw, 2017-06-02 15:25:15]

https://codereview.chromium.org/2915223002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc (left):

https://codereview.chromium.org/2915223002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc:68:
ash::kShelfIDKey, ui::mojom::WindowManager::kShelfID_Property);
On 2017/06/02 13:36:39, sky wrote:
> Ideally clients would not have to do anything special to have their windows
> appear in the shelf. What would it take to make that happen? Say for example
> having task viewers window appear in the shelf without having task view
> explicitly set the type and shelf id.

We would need some way to (a) disambiguate windows that should be shown in the
shelf, like task_viewer, and windows that shouldn't, like chrome's 'restore
pages?' bubble (which is apparently a top-level window, perhaps with a transient
parent? maybe filter by aura::Window::type?), and (b) we'd need to do something
like my old ShelfWindowWatcher hack that assigned arbitrary types and ids to
windows before (or in lieu) of Chrome/app doing so, then fix that up once
Chrome/app assigns an id and a type, I'd essentially be restoring the code i
removed here:
https://codereview.chromium.org/2833173002/diff/340001/ash/shelf/shelf_window...

[sky, 2017-06-02 17:18:08]

sky@chromium.org changed reviewers:
+ oshima@chromium.org

[sky, 2017-06-02 17:24:47]

I like the idea of ignoring windows with transient parents. A variation on this
is to have a property that indicates whether an item is shown by the shelf
(property is defined in aura_constants and window_manager.mojom). Default is
true, but views code sets the property to false if the window has a transient
parent. This way we could toggle the property to true if we have a case where
there is a transient window *and* we wanted a shelf item. I'm not sure we
actually have that though. I'm not sure we actually need complexity though.

Also note, ash::wm::WindowState has a property as to whether the window is shown
in the state. The status bubble in views explicitly sets this to false. The
status bubble has a transient parent, so if we made it so transient parents
aren't shown in the shelf we would no longer need to special case status bubble
code in chrome.

+oshima, can you think of any cases where we have a window with a transient
parent *and* want it shown in the shelf?

[msw, 2017-06-02 23:13:24]

Description was changed from

==========
mash: Fix mash app shelf items; encapsulate ash property setup.

Add ash::RegisterWindowPropertiesForTransportAndMirroring()
(allows mus clients to setup window properties for transport)

Call this from Chrome, QuickLaunch, other mash apps.
Set QuickLaunch, etc. properties to show on the shelf.
note: 'window_type_launcher' & 'task_viewer' don't launch on ToT.

Make ShowExamplesWindow return a widget for client use.

OPTIONAL: Use the new function in ash::WindowManager's ctor?
TODO: Fix QuickLaunch ShelfButtons ink-drop crash on 2nd click.

BUG=557406
TEST=chrome --mash shows a shelf item for QuickLaunch.
R=sky@chromium.org
==========

to

==========
ABANDONED IN FAVOR OF https://codereview.chromium.org/2918223002

mash: Fix mash app shelf items; encapsulate ash property setup.

Add ash::RegisterWindowPropertiesForTransportAndMirroring()
(allows mus clients to setup window properties for transport)

Call this from Chrome, QuickLaunch, other mash apps.
Set QuickLaunch, etc. properties to show on the shelf.
note: 'window_type_launcher' & 'task_viewer' don't launch on ToT.

Make ShowExamplesWindow return a widget for client use.

OPTIONAL: Use the new function in ash::WindowManager's ctor?
TODO: Fix QuickLaunch ShelfButtons ink-drop crash on 2nd click.

BUG=557406
TEST=chrome --mash shows a shelf item for QuickLaunch.
R=sky@chromium.org
==========

[msw, 2017-06-02 23:15:24]

On 2017/06/02 17:24:47, sky wrote:
> I like the idea of ignoring windows with transient parents. A variation on
this
> is to have a property that indicates whether an item is shown by the shelf
> (property is defined in aura_constants and window_manager.mojom). Default is
> true, but views code sets the property to false if the window has a transient
> parent. This way we could toggle the property to true if we have a case where
> there is a transient window *and* we wanted a shelf item. I'm not sure we
> actually have that though. I'm not sure we actually need complexity though.
> 
> Also note, ash::wm::WindowState has a property as to whether the window is
shown
> in the state. The status bubble in views explicitly sets this to false. The
> status bubble has a transient parent, so if we made it so transient parents
> aren't shown in the shelf we would no longer need to special case status
bubble
> code in chrome.
> 
> +oshima, can you think of any cases where we have a window with a transient
> parent *and* want it shown in the shelf?

I followed your suggestion in https://codereview.chromium.org/2918223002
This CL is unnecessary/abandoned, but it might still make sense to extract
ash::RegisterWindowPropertiesForTransportAndMirroring().