Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 2918133002: [Merge M60][Payments] Refactor the year and month combobox models and preselect. (Closed)

Created:
3 years, 6 months ago by Mathieu
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

[Merge M60][Payments] Refactor the year and month combobox models and preselect. Few changes: * In CVC screen, will preselect the invalid expiration values. * Using YearComboboxModel and MonthComboboxModel in credit card editor * An expired card will not appear as such in the Payment Sheet and Payment method screens. User will have the option to fix the expiration at the CVC step. Bug: 726394 Test: unit_tests, browser_tests Change-Id: I680e6d6978d60be6b1f6758e76e0d1b9c4b6b096 Reviewed-on: https://chromium-review.googlesource.com/516963 Commit-Queue: Mathieu Perreault <mathp@chromium.org>; Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>; Reviewed-by: Anthony Vallee-Dubois <anthonyvd@chromium.org>; Cr-Original-Commit-Position: refs/heads/master@{#475105} Review-Url: https://codereview.chromium.org/2918133002 . Cr-Commit-Position: refs/branch-heads/3112@{#115} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/46753fc62b6bd42addf1146bf972c9cad073c2b2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -346 lines) Patch
M chrome/browser/ui/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_models.h View 3 chunks +6 lines, -11 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_models.cc View 3 chunks +45 lines, -29 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_models_unittest.cc View 1 chunk +79 lines, -1 line 0 comments Download
M chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc View 4 chunks +4 lines, -56 lines 0 comments Download
M chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc View 2 chunks +14 lines, -5 lines 0 comments Download
D chrome/browser/ui/views/payments/credit_card_editor_view_controller_unittest.cc View 1 chunk +0 lines, -168 lines 0 comments Download
M chrome/browser/ui/views/payments/cvc_unmask_view_controller.cc View 3 chunks +8 lines, -0 lines 0 comments Download
D chrome/browser/ui/views/payments/preselected_combobox_model.h View 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/browser/ui/views/payments/preselected_combobox_model.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/core/browser/credit_card.h View 1 chunk +3 lines, -3 lines 0 comments Download
M components/autofill/core/browser/validation.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/payments/core/autofill_payment_instrument.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M components/payments/core/autofill_payment_instrument_unittest.cc View 3 chunks +6 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Mathieu
3 years, 6 months ago (2017-06-02 15:21:28 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
46753fc62b6bd42addf1146bf972c9cad073c2b2.

Powered by Google App Engine
This is Rietveld 408576698