[Merge M60][Payments] Refactor the year and month combobox models and preselect.

chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/payments/credit_card_editor_view_controller.h"
 
 #include <memory>
 #include <string>
 #include <utility>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/memory/ptr_util.h"
 #include "base/strings/string16.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
+#include "chrome/browser/ui/autofill/autofill_dialog_models.h"
 #include "chrome/browser/ui/views/payments/payment_request_dialog_view.h"
 #include "chrome/browser/ui/views/payments/payment_request_dialog_view_ids.h"
 #include "chrome/browser/ui/views/payments/payment_request_views_util.h"
-#include "chrome/browser/ui/views/payments/preselected_combobox_model.h"
 #include "chrome/browser/ui/views/payments/validating_combobox.h"
 #include "chrome/browser/ui/views/payments/validating_textfield.h"
 #include "chrome/grit/generated_resources.h"
 #include "components/autofill/core/browser/address_combobox_model.h"
 #include "components/autofill/core/browser/autofill_data_util.h"
 #include "components/autofill/core/browser/autofill_type.h"
 #include "components/autofill/core/browser/credit_card.h"
 #include "components/autofill/core/browser/field_types.h"
 #include "components/autofill/core/browser/personal_data_manager.h"
 #include "components/autofill/core/browser/validation.h"
@@ skipping 10 matching lines @@
 #include "ui/views/controls/textfield/textfield.h"
 #include "ui/views/layout/box_layout.h"
 #include "ui/views/layout/fill_layout.h"
 #include "ui/views/layout/grid_layout.h"
 #include "ui/views/view.h"
 
 namespace payments {
 
 namespace {
 
-// Number of years to be shown in the expiration year dropdown. If the card's
-// year is outside of the range of
-// [currentYear, currentYear+kNumberOfExpirationYears], then the UI shows an
-// additional entry for the card's expiration year.
-const int kNumberOfExpirationYears = 10;
-
 // Opacity of card network icons when they are not selected and are displayed
 // alongside a selected icon.
 const float kDimmedCardIconOpacity = 0.33f;
 
 // This is not quite right but is the closest server type that wasn't already
 // used.
 const auto kBillingAddressType = autofill::ADDRESS_BILLING_LINE1;
 
-// Returns the items that are in the expiration month dropdown. Will return the
-// months in order starting at "01" until "12". Uses a clock so that the
-// |default_index| is set to the current month.
-std::vector<base::string16> GetExpirationMonthItems(int* default_index) {
-  std::vector<base::string16> months;
-  months.reserve(12);
-  for (int i = 1; i <= 12; i++)
-    months.push_back(base::UTF8ToUTF16(base::StringPrintf("%02d", i)));
-
-  base::Time::Exploded now_exploded;
-  autofill::AutofillClock::Now().LocalExplode(&now_exploded);
-  *default_index = now_exploded.month - 1;
-
-  return months;
-}
-
-// Returns the items that are in the expiration year dropdown.
-std::vector<base::string16> GetExpirationYearItems(
-    const autofill::CreditCard* card_to_edit) {
-  std::vector<base::string16> years;
-  years.reserve(kNumberOfExpirationYears + 1);
-
-  base::Time::Exploded now_exploded;
-  autofill::AutofillClock::Now().LocalExplode(&now_exploded);
-
-  if (card_to_edit && card_to_edit->expiration_year() < now_exploded.year) {
-    years.push_back(
-        base::UTF8ToUTF16(std::to_string(card_to_edit->expiration_year())));
-  }
-
-  for (int i = 0; i < kNumberOfExpirationYears; i++) {
-    years.push_back(base::UTF8ToUTF16(std::to_string(now_exploded.year + i)));
-  }
-
-  if (card_to_edit && card_to_edit->expiration_year() >=
-                          now_exploded.year + kNumberOfExpirationYears) {
-    years.push_back(
-        base::UTF8ToUTF16(std::to_string(card_to_edit->expiration_year())));
-  }
-
-  return years;
-}
-
 bool IsCardExpired(const base::string16& month,
                    const base::string16& year,
                    const std::string& app_locale) {
   autofill::CreditCard card;
   card.SetExpirationMonthFromString(month, app_locale);
   card.SetExpirationYearFromString(year);
   return card.IsExpired(autofill::AutofillClock::Now());
 }
 
 // Validates the two comboboxes used for expiration date.
@@ skipping 406 matching lines @@
   return base::MakeUnique<
       CreditCardEditorViewController::CreditCardValidationDelegate>(field,
                                                                     this);
 }
 
 std::unique_ptr<ui::ComboboxModel>
 CreditCardEditorViewController::GetComboboxModelForType(
     const autofill::ServerFieldType& type) {
   switch (type) {
     case autofill::CREDIT_CARD_EXP_MONTH: {
-      int default_index = 0;
-      std::vector<base::string16> months =
-          GetExpirationMonthItems(&default_index);
-      return base::MakeUnique<PreselectedComboboxModel>(months, default_index);
+      return base::MakeUnique<autofill::MonthComboboxModel>();
     }
     case autofill::CREDIT_CARD_EXP_4_DIGIT_YEAR:
-      return base::MakeUnique<ui::SimpleComboboxModel>(
-          GetExpirationYearItems(credit_card_to_edit_));
+      return base::MakeUnique<autofill::YearComboboxModel>(
+          credit_card_to_edit_ ? credit_card_to_edit_->expiration_year() : 0);
     case kBillingAddressType:
       // The combobox filled with potential billing addresses. It's fine to pass
       // empty string as the default selected guid if there are no cards being
       // edited.
       return base::MakeUnique<autofill::AddressComboboxModel>(
           *state()->GetPersonalDataManager(), state()->GetApplicationLocale(),
           credit_card_to_edit_ ? credit_card_to_edit_->billing_address_id()
                                : "");
     default:
       NOTREACHED();
@@ skipping 212 matching lines @@
   return ValidateValue(combobox->GetTextForRow(combobox->selected_index()),
                        error_message);
 }
 
 bool CreditCardEditorViewController::GetSheetId(DialogViewID* sheet_id) {
   *sheet_id = DialogViewID::CREDIT_CARD_EDITOR_SHEET;
   return true;
 }
 
 }  // namespace payments