chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_test_utils.cc - Issue 2918053003: Settings reset prompt: Fetch default settings only when needed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_test_utils.cc

Issue 2918053003: Settings reset prompt: Fetch default settings only when needed. (Closed)

Patch Set: Addressed Chris's comment Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_model_unittest.cc ('k') | chrome/browser/ui/views/settings_reset_prompt_dialog_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_test_utils.cc

diff --git a/chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_test_utils.cc b/chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_test_utils.cc

index 902fc7965e95355e8b1aa4bc584b4d76661be574..bb50eb288baa001112ce9394b53a297d51314409 100644

--- a/chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_test_utils.cc

+++ b/chrome/browser/safe_browsing/settings_reset_prompt/settings_reset_prompt_test_utils.cc

@@ -52,10 +52,8 @@ std::unique_ptr<SettingsResetPromptModel> CreateModelForTesting(

++id;

}

- return SettingsResetPromptModel::CreateForTesting(

+ return base::MakeUnique<SettingsResetPromptModel>(

profile, std::move(config),

- base::MakeUnique<ResettableSettingsSnapshot>(profile),

- base::MakeUnique<BrandcodedDefaultSettings>(),

profile_resetter

? std::move(profile_resetter)

: base::MakeUnique<NiceMock<MockProfileResetter>>(profile));