[iOS Clean] Update ContextMenuItem to use a single command.

[iOS Clean] Update ContextMenuItem to use a single command.

Rather than passing a vector of commands, use a single command and
send |-hideContextMenu:| directly from the ContextMenuViewController
if the command doesn't open a new tab.

BUG=none

Review-Url: https://codereview.chromium.org/2917973002
Cr-Commit-Position: refs/heads/master@{#476849}
Committed: https://chromium.googlesource.com/chromium/src/+/6cd2c7a3e911e023f62536ff9d939f516badb961

[kkhorimoto, 2017-06-01 23:08:12]

kkhorimoto@chromium.org changed reviewers:
+ edchin@chromium.org, marq@chromium.org

[kkhorimoto, 2017-06-01 23:08:13]

Follow-up from CL feedback on https://codereview.chromium.org/2862783002/

[marq (ping after 24h), 2017-06-02 09:35:41]

LGTM -- this is exactly the simplification I had in mind.

https://codereview.chromium.org/2917973002/diff/1/ios/clean/chrome/browser/ui...
File ios/clean/chrome/browser/ui/context_menu/context_menu_item.h (right):

https://codereview.chromium.org/2917973002/diff/1/ios/clean/chrome/browser/ui...
ios/clean/chrome/browser/ui/context_menu/context_menu_item.h:30:
@property(nonatomic, readonly, assign) BOOL commandOpensTab;
Optional: it can probably be just 'opensTab'.

[kkhorimoto, 2017-06-02 18:38:23]

Description was changed from

==========
Update ContextMenuItem to use a single command.

Rather than passing a vector of commands, use a single command and
send |-hideContextMenu:| directly from the ContextMenuViewController
if the command doesn't open a new tab.

BUG=none
==========

to

==========
[iOS Clean] Update ContextMenuItem to use a single command.

Rather than passing a vector of commands, use a single command and
send |-hideContextMenu:| directly from the ContextMenuViewController
if the command doesn't open a new tab.

BUG=none
==========

[kkhorimoto, 2017-06-02 21:23:07]

rebase

[kkhorimoto, 2017-06-02 21:23:07]

The CQ bit was checked by kkhorimoto@chromium.org

[kkhorimoto, 2017-06-02 21:23:08]

The patchset sent to the CQ was uploaded after l-g-t-m from marq@chromium.org
Link to the patchset: https://codereview.chromium.org/2917973002/#ps20001
(title: "rebase")

[kkhorimoto, 2017-06-02 21:23:24]

https://codereview.chromium.org/2917973002/diff/1/ios/clean/chrome/browser/ui...
File ios/clean/chrome/browser/ui/context_menu/context_menu_item.h (right):

https://codereview.chromium.org/2917973002/diff/1/ios/clean/chrome/browser/ui...
ios/clean/chrome/browser/ui/context_menu/context_menu_item.h:30:
@property(nonatomic, readonly, assign) BOOL commandOpensTab;
On 2017/06/02 09:35:40, marq (ping after 24h) wrote:
> Optional: it can probably be just 'opensTab'.

Acknowledged.

[commit-bot: I haz the power, 2017-06-02 21:23:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 21:23:45]

This CL has an open dependency (Issue 2922573002 Patch 20001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[kkhorimoto, 2017-06-02 21:52:24]

The CQ bit was checked by kkhorimoto@chromium.org

[commit-bot: I haz the power, 2017-06-02 21:52:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-03 01:35:36]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496440344355500,
"parent_rev": "9aa11de928b45b4bf70124d926f9359d8d48586c", "commit_rev":
"6cd2c7a3e911e023f62536ff9d939f516badb961"}

[commit-bot: I haz the power, 2017-06-03 01:35:49]

Description was changed from

==========
[iOS Clean] Update ContextMenuItem to use a single command.

Rather than passing a vector of commands, use a single command and
send |-hideContextMenu:| directly from the ContextMenuViewController
if the command doesn't open a new tab.

BUG=none
==========

to

==========
[iOS Clean] Update ContextMenuItem to use a single command.

Rather than passing a vector of commands, use a single command and
send |-hideContextMenu:| directly from the ContextMenuViewController
if the command doesn't open a new tab.

BUG=none

Review-Url: https://codereview.chromium.org/2917973002
Cr-Commit-Position: refs/heads/master@{#476849}
Committed:
https://chromium.googlesource.com/chromium/src/+/6cd2c7a3e911e023f62536ff9d93...
==========

[commit-bot: I haz the power, 2017-06-03 01:35:51]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6cd2c7a3e911e023f62536ff9d93...