Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2922573002: [iOS Clean] Ignore compiler warnings for |-performSelector:withObject:|. (Closed)

Created:
3 years, 6 months ago by kkhorimoto
Modified:
3 years, 6 months ago
CC:
chromium-reviews, marq+scrutinize_chromium.org, ios-reviews+clean_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS Clean] Ignore compiler warnings for |-performSelector:withObject:|. BUG=none Review-Url: https://codereview.chromium.org/2922573002 Cr-Commit-Position: refs/heads/master@{#476803} Committed: https://chromium.googlesource.com/chromium/src/+/15e1023261ee539b7d0037c2bb57596b48ca3ae3

Patch Set 1 #

Total comments: 2

Patch Set 2 : added comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M ios/clean/chrome/browser/ui/context_menu/context_menu_view_controller.mm View 1 1 chunk +8 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (5 generated)
kkhorimoto
3 years, 6 months ago (2017-06-01 22:26:28 UTC) #2
marq (ping after 24h)
LGTM with nit, thanks for making this change. https://codereview.chromium.org/2922573002/diff/1/ios/clean/chrome/browser/ui/context_menu/context_menu_view_controller.mm File ios/clean/chrome/browser/ui/context_menu/context_menu_view_controller.mm (right): https://codereview.chromium.org/2922573002/diff/1/ios/clean/chrome/browser/ui/context_menu/context_menu_view_controller.mm#newcode23 ios/clean/chrome/browser/ui/context_menu/context_menu_view_controller.mm:23: #pragma ...
3 years, 6 months ago (2017-06-02 08:28:35 UTC) #3
kkhorimoto
added comment
3 years, 6 months ago (2017-06-02 21:17:12 UTC) #4
kkhorimoto
https://codereview.chromium.org/2922573002/diff/1/ios/clean/chrome/browser/ui/context_menu/context_menu_view_controller.mm File ios/clean/chrome/browser/ui/context_menu/context_menu_view_controller.mm (right): https://codereview.chromium.org/2922573002/diff/1/ios/clean/chrome/browser/ui/context_menu/context_menu_view_controller.mm#newcode23 ios/clean/chrome/browser/ui/context_menu/context_menu_view_controller.mm:23: #pragma clang diagnostic push On 2017/06/02 08:28:35, marq (ping ...
3 years, 6 months ago (2017-06-02 21:17:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2922573002/20001
3 years, 6 months ago (2017-06-02 21:17:59 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 21:44:39 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/15e1023261ee539b7d0037c2bb57...

Powered by Google App Engine
This is Rietveld 408576698