Ignore download bytes in page load metrics.

Ignore download bytes in page load metrics.

We currently end up ignoring download bytes by chance. 
This change makes us explicitly ignore download bytes, and
adds a test.

BUG=728696
Review-Url: https://codereview.chromium.org/2917873003
Cr-Commit-Position: refs/heads/master@{#476710}
Committed: https://chromium.googlesource.com/chromium/src/+/71a51d537b4bf80c9a30223bc916c05f373462a2

[Bryan McQuade, 2017-06-01 16:42:09]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-01 16:42:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bryan McQuade, 2017-06-01 16:49:25]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-01 16:50:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bryan McQuade, 2017-06-01 17:30:49]

Description was changed from

==========
Ignore download bytes in page load metrics.

BUG=
==========

to

==========
Ignore download bytes in page load metrics.

We currently end up ignoring download bytes by chance. 
This change makes us explicitly ignore download bytes, and
adds a test.

BUG=728696
==========

[Bryan McQuade, 2017-06-01 17:30:49]

bmcquade@chromium.org changed reviewers:
+ csharrison@chromium.org, jkarlin@chromium.org

[Bryan McQuade, 2017-06-01 17:31:03]

PTAL, thanks!

[Charlie Harrison, 2017-06-01 17:49:13]

LGTM

https://codereview.chromium.org/2917873003/diff/20001/chrome/test/data/page_l...
File chrome/test/data/page_load_metrics/download_anchor_click.html (right):

https://codereview.chromium.org/2917873003/diff/20001/chrome/test/data/page_l...
chrome/test/data/page_load_metrics/download_anchor_click.html:6:
window.setTimeout(function() {
Can you explain why we need setTimeout?

[jkarlin, 2017-06-01 18:09:47]

lgtm

[commit-bot: I haz the power, 2017-06-01 18:18:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 18:18:42]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Bryan McQuade, 2017-06-02 15:55:12]

The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 15:55:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 17:28:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 17:28:03]

Dry run: This issue passed the CQ dry run.

[Bryan McQuade, 2017-06-02 17:38:28]

https://codereview.chromium.org/2917873003/diff/20001/chrome/test/data/page_l...
File chrome/test/data/page_load_metrics/download_anchor_click.html (right):

https://codereview.chromium.org/2917873003/diff/20001/chrome/test/data/page_l...
chrome/test/data/page_load_metrics/download_anchor_click.html:6:
window.setTimeout(function() {
On 2017/06/01 at 17:49:13, Charlie Harrison wrote:
> Can you explain why we need setTimeout?

sure, added a comment, thanks!

[Bryan McQuade, 2017-06-02 17:38:30]

The CQ bit was checked by bmcquade@chromium.org

[Bryan McQuade, 2017-06-02 17:38:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkarlin@chromium.org, csharrison@chromium.org
Link to the patchset: https://codereview.chromium.org/2917873003/#ps40001
(title: "address comment")

[commit-bot: I haz the power, 2017-06-02 17:38:58]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 17:42:22]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496425110881440,
"parent_rev": "0751c8c42a45606d3a752ec6fa2b6139650bbb5a", "commit_rev":
"71a51d537b4bf80c9a30223bc916c05f373462a2"}

[commit-bot: I haz the power, 2017-06-02 17:42:32]

Description was changed from

==========
Ignore download bytes in page load metrics.

We currently end up ignoring download bytes by chance. 
This change makes us explicitly ignore download bytes, and
adds a test.

BUG=728696
==========

to

==========
Ignore download bytes in page load metrics.

We currently end up ignoring download bytes by chance. 
This change makes us explicitly ignore download bytes, and
adds a test.

BUG=728696

Review-Url: https://codereview.chromium.org/2917873003
Cr-Commit-Position: refs/heads/master@{#476710}
Committed:
https://chromium.googlesource.com/chromium/src/+/71a51d537b4bf80c9a30223bc916...
==========

[commit-bot: I haz the power, 2017-06-02 17:42:33]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/71a51d537b4bf80c9a30223bc916...